<div dir="ltr">Hi!<div><br></div><div>I'm here, and as you can tell have been working my way through my review queue. I'm trying to get to them mostly in the order I received them originally so I should get to it soon.</div><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 7, 2018 at 9:06 AM Yonghong Song <<a href="mailto:yhs@fb.com">yhs@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, Eric,<br>
<br>
I noticed that the llvm 8.0.0 will be branched out on Jan 16, 2019.<br>
I am not sure about your holiday schedule and I worried that this may<br>
get even more delayed as Christmas approaches. It will be really good<br>
if you can allocate some time to review this patch soon.<br>
<br>
Also, I noticed that my multiple reminders on phabricator generated<br>
no response from you and I am not even sure that this email will<br>
be able to reach you or not. Previous email communication is due<br>
to merge and revert the patch. Further back an email communication<br>
is an email directly addressed to you.<br>
<br>
If you see this email and really do not have time to review it now,<br>
could you still reply like you saw this email and will review later<br>
so I know that you can still reach/ping you through this email thread?<br>
<br>
Thanks,<br>
<br>
Yonghong<br>
<br>
On 12/4/18 12:42 PM, Yonghong Song wrote:<br>
> <br>
> Hi, Eric,<br>
> <br>
> Just a kind reminder that it would be great if you can squeeze some time<br>
> to review the patch.<br>
> <br>
> Thanks!<br>
> <br>
> Yonghong<br>
> <br>
> <br>
> On 11/30/18 8:56 AM, Eric Christopher wrote:<br>
>> FWIW I do like the new patch direction and hope to get to this shortly.<br>
>><br>
>> On Fri, Nov 30, 2018, 8:51 AM Yonghong Song <<a href="mailto:yhs@fb.com" target="_blank">yhs@fb.com</a> <br>
>> <mailto:<a href="mailto:yhs@fb.com" target="_blank">yhs@fb.com</a>>> wrote:<br>
>><br>
>><br>
>> I will revert it now.<br>
>><br>
>> On 11/30/18 8:49 AM, Eric Christopher wrote:<br>
>> > So Adrian didn't accept this and it touches code that Alexei <br>
>> doesn't<br>
>> > have any real experience (as far as I know) with so it isn't<br>
>> appropriate<br>
>> > for you to land this without approval. I understand you've been<br>
>> waiting<br>
>> > for a while, but that's not a good enough reason. Please revert<br>
>> for now<br>
>> > until we can look.<br>
>> ><br>
>> > On Fri, Nov 30, 2018, 8:25 AM Phabricator via Phabricator<br>
>> > <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a> <mailto:<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>><br>
>> <mailto:<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a> <mailto:<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>>>><br>
>> wrote:<br>
>> ><br>
>> > This revision was not accepted when it landed; it landed in <br>
>> state<br>
>> > "Needs Review".<br>
>> > This revision was automatically updated to reflect the <br>
>> committed<br>
>> > changes.<br>
>> > Closed by commit rL347999: [BTF] Add BTF DebugInfo (authored<br>
>> by yhs,<br>
>> > committed by ).<br>
>> ><br>
>> > Changed prior to commit:<br>
>> > <a href="https://reviews.llvm.org/D53736?vs=174527&id=176133#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D53736?vs=174527&id=176133#toc</a><br>
>> <br>
>> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=eV5zffARXFpMPlLta8ho2Kxy9PdTMzUkxV9bVTtGKuI&s=ffbr3Y43MuGLV5hak5U2PehlCma1LfFogd9MuKBgSrk&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=eV5zffARXFpMPlLta8ho2Kxy9PdTMzUkxV9bVTtGKuI&s=ffbr3Y43MuGLV5hak5U2PehlCma1LfFogd9MuKBgSrk&e=</a>> <br>
>><br>
>> > <br>
>> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=zPdsdNZ1_DF0UBWsU_9yoevmReH_8IqNEs335p6L0gs&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736-3Fvs-3D174527-26id-3D176133-23toc&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=zPdsdNZ1_DF0UBWsU_9yoevmReH_8IqNEs335p6L0gs&e=</a>> <br>
>><br>
>> ><br>
>> > Repository:<br>
>> > rL LLVM<br>
>> ><br>
>> > CHANGES SINCE LAST ACTION<br>
>> > <a href="https://reviews.llvm.org/D53736/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D53736/new/</a><br>
>> <br>
>> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=eV5zffARXFpMPlLta8ho2Kxy9PdTMzUkxV9bVTtGKuI&s=yrmL8h7o4HndoVuzMkR1VcwF2SBKExGZDBXUwg6Gm_Y&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=eV5zffARXFpMPlLta8ho2Kxy9PdTMzUkxV9bVTtGKuI&s=yrmL8h7o4HndoVuzMkR1VcwF2SBKExGZDBXUwg6Gm_Y&e=</a>> <br>
>><br>
>> > <br>
>> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=OsDyTNnwqfvfxsEmM2PHsDO9fRXyB3fe9fCb2UmxtsY&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736_new_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=OsDyTNnwqfvfxsEmM2PHsDO9fRXyB3fe9fCb2UmxtsY&e=</a>> <br>
>><br>
>> ><br>
>> > <a href="https://reviews.llvm.org/D53736" rel="noreferrer" target="_blank">https://reviews.llvm.org/D53736</a><br>
>> <br>
>> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=eV5zffARXFpMPlLta8ho2Kxy9PdTMzUkxV9bVTtGKuI&s=Q3ec5ZHnBt6_mtJh4cqHwIT1ETLlMvEFzJn4HI_ncYU&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=eV5zffARXFpMPlLta8ho2Kxy9PdTMzUkxV9bVTtGKuI&s=Q3ec5ZHnBt6_mtJh4cqHwIT1ETLlMvEFzJn4HI_ncYU&e=</a>> <br>
>><br>
>> > <br>
>> <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=YSLbTE6YZuqlk1kytiaV1RA80fKpF4HJU11eMc1gA2Q&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=oest39Lss5_5lx6NZgWa9qhPYwGcCe2RjWValScV-rw&s=YSLbTE6YZuqlk1kytiaV1RA80fKpF4HJU11eMc1gA2Q&e=</a>> <br>
>><br>
>> ><br>
>> > Files:<br>
>> > llvm/trunk/include/llvm/BinaryFormat/BTF.def<br>
>> > llvm/trunk/include/llvm/BinaryFormat/BTF.h<br>
>> > llvm/trunk/include/llvm/MC/MCObjectFileInfo.h<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebug.cpp<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebug.h<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/BTFDebugStub.cpp<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/CMakeLists.txt<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp<br>
>> > llvm/trunk/lib/CodeGen/AsmPrinter/DebugHandlerBase.h<br>
>> > llvm/trunk/lib/MC/MCObjectFileInfo.cpp<br>
>> > llvm/trunk/test/DebugInfo/BTF/array-1d-char.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/array-1d-int.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/array-2d-int.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/array-size-0.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/array-typedef.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/binary-format.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/char.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/enum-basic.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/func-func-ptr.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/func-non-void.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/func-source.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/func-typedef.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/func-unused-arg.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/func-void.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/fwd-no-define.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/fwd-with-define.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/int.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/lit.local.cfg<br>
>> > llvm/trunk/test/DebugInfo/BTF/longlong.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-const-void.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-func-1.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-func-2.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-func-3.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-int.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-void.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-volatile-const-void.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ptr-volatile-void.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/restrict-ptr.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/short.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/struct-anon.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/struct-basic.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/struct-bitfield-typedef.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/struct-enum.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/uchar.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/uint.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ulonglong.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/union-array-typedef.ll<br>
>> > llvm/trunk/test/DebugInfo/BTF/ushort.ll<br>
>> ><br>
>><br>
</blockquote></div>