<div dir="ltr">ok. thanks.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 15, 2018 at 9:31 AM Xin Tong via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">trentxintong added inline comments.<br>
<br>
<br>
================<br>
Comment at: lib/Passes/PassBuilder.cpp:1006<br>
+    // Load sample profile before running the LTO optimization pipeline.<br>
+    MPM.addPass(SampleProfileLoaderPass(PGOOpt->SampleProfileFile,<br>
+                                        PGOOpt->ProfileRemappingFile,<br>
----------------<br>
davidxl wrote:<br>
> I thought sample profile is already loaded twice -- one in FE and one in backend compilation. Is it not the case?<br>
I see thats the case for ThinLTO. but not for LTO.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D54564" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54564</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>