<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I've reverted this at rL345451 - but if you can send me an
example of a failing test (was it an assert or bad codegen?)
that'd be great - my own fuzz tests haven't found anything and I
need to fix this to support combining shuffle with subvectors. </p>
<div class="moz-cite-prefix">On 26/10/2018 21:50, Eric Christopher
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CALehDX7t+ZBW3TZSmKXg4f1svZO0mvE0vi7YiLVKP9uqvBOK7g@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">Hi Simon,
<div><br>
</div>
<div>I'm working on why at the moment, but I am seeing some
failures due to this patch. I think you were meaning to make
it NFC, but that part didn't happen :)</div>
<div><br>
</div>
<div>-eric</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Fri, Oct 26, 2018 at 8:21 AM Simon Pilgrim via
llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org"
moz-do-not-send="true">llvm-commits@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
rksimon<br>
Date: Fri Oct 26 08:19:02 2018<br>
New Revision: 345395<br>
<br>
URL: <a
href="http://llvm.org/viewvc/llvm-project?rev=345395&view=rev"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project?rev=345395&view=rev</a><br>
Log:<br>
[X86][SSE] Move 2-input limit up from getFauxShuffleMask to
resolveTargetShuffleInputs<br>
<br>
Makes no difference to actual shuffle decoding yet, but merges
all the existing limits in one place for when proper support
is fixed.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
URL: <a
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=345395&r1=345394&r2=345395&view=diff"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=345395&r1=345394&r2=345395&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Oct 26
08:19:02 2018<br>
@@ -6325,9 +6325,6 @@ static bool getFauxShuffleMask(SDValue N<br>
if (!resolveTargetShuffleInputs(N0, SrcInputs0, SrcMask0,
DAG) ||<br>
!resolveTargetShuffleInputs(N1, SrcInputs1, SrcMask1,
DAG))<br>
return false;<br>
- // TODO - Add support for more than 2 inputs.<br>
- if ((SrcInputs0.size() + SrcInputs1.size()) > 2)<br>
- return false;<br>
int MaskSize = std::max(SrcMask0.size(),
SrcMask1.size());<br>
SmallVector<int, 64> Mask0, Mask1;<br>
scaleShuffleMask<int>(MaskSize / SrcMask0.size(),
SrcMask0, Mask0);<br>
@@ -6387,8 +6384,7 @@ static bool getFauxShuffleMask(SDValue N<br>
Mask[i + InsertIdx] = (NumElts * (1 + InputIdx)) +
ExtractIdx + M;<br>
}<br>
}<br>
- // TODO - Add support for more than 1 subinput.<br>
- return Ops.size() <= 2;<br>
+ return true;<br>
}<br>
case ISD::SCALAR_TO_VECTOR: {<br>
// Match against a scalar_to_vector of an extract from a
vector,<br>
@@ -6581,7 +6577,7 @@ static bool resolveTargetShuffleInputs(S<br>
return false;<br>
<br>
resolveTargetShuffleInputsAndMask(Inputs, Mask);<br>
- return true;<br>
+ return Inputs.size() <= 2;<br>
}<br>
<br>
/// Returns the scalar element that will make up the ith<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank"
moz-do-not-send="true">llvm-commits@lists.llvm.org</a><br>
<a
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>