<div dir="ltr">Hmm, is this my change? My change replaced assert() with llvm_unreachable() to fix that warning.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 12, 2018 at 12:27 PM Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr">this causes a warning (treated as error) and <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/15955/steps/annotate/logs/stdio" target="_blank">displeases the bots</a>:<div><div>llvm/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp:195:12: warning: implicit conversion turns string literal into bool: 'const char [42]' to 'bool' [-Wstring-conversion]</div><div>    assert("Invalid Die passed into BTFTypeEntryInt()");</div><div>    ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</div><div>/usr/include/assert.h:89:5: note: expanded from macro 'assert'</div><div>  ((expr)                                                               \</div><div>    ^~~~</div></div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 12, 2018 at 11:31 AM Rui Ueyama via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Fri Oct 12 11:29:30 2018<br>
New Revision: 344395<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=344395&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=344395&view=rev</a><br>
Log:<br>
Replace assert() with llvm_unreachable because it's obviously a typo.<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp?rev=344395&r1=344394&r2=344395&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp?rev=344395&r1=344394&r2=344395&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/Dwarf2BTF.cpp Fri Oct 12 11:29:30 2018<br>
@@ -155,7 +155,7 @@ Die2BTFEntry::Die2BTFEntry(const DIE &Di<br>
   case BTF_KIND_VOLATILE:<br>
     break;<br>
   default:<br>
-    assert("Invalid Die passed into BTFTypeEntry()");<br>
+    llvm_unreachable("Invalid Die passed into BTFTypeEntry()");<br>
     break;<br>
   }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>