<div dir="ltr">I'm actually going to revert it temporarily as the new patch broke something else. I'll work on a fix and then resubmit all at once.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 11, 2018 at 11:03 AM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hopefully this is all fixed by r344269.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 11, 2018 at 10:19 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I have a repro. It's more complicated than I was hoping for to fix. I'm still trying, but if it doesn't lend itself to a fix in the next half hour or so I'm going to mark the tests as XFAIL on non-Windows while I continue working on it.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 11, 2018 at 10:14 AM Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank">stilis@microsoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-4318189979030007548m_-6725362069722844241m_-585613557497438892WordSection1">
<p class="MsoNormal">I took a quick look at the FileCheck issue and it looks like these have been failing since mid-September!<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">That’s when the change to use filecheck inside the LLDB tests as a function went in:
<a href="https://reviews.llvm.org/D50751" target="_blank">https://reviews.llvm.org/D50751</a>. The change adds a new required input to dotests.py and updates the cmake files to pass it as well as the xcode project, but any of the bots that are calling dotests.py directly now
need to pass the new input too.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Vedant, since you made the change, how do you feel about logging a warning instead of hard failing inside dotests.py and then hardfailing any tests that use filecheck when it doesn’t exist? That would limit the failures just to those tests
instead of all of the tests on these bots. The bot owners will have to update the scripts as well.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Zachary, if you can’t get a local repro of the windows or linux failure with your changes, I can get you the logs from our test runs.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">-Stella<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><b>From:</b> Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> <br>
<b>Sent:</b> Wednesday, October 10, 2018 8:23 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD53002%2Bpublic%2B9ea58f85247e05d8@reviews.llvm.org" target="_blank">reviews+D53002+public+9ea58f85247e05d8@reviews.llvm.org</a><br>
<b>Cc:</b> <a href="mailto:aleksandr.urakov@jetbrains.com" target="_blank">aleksandr.urakov@jetbrains.com</a>; aaron.lee.smith <<a href="mailto:aaron.lee.smith@gmail.com" target="_blank">aaron.lee.smith@gmail.com</a>>; Stella Stamenova <<a href="mailto:stilis@microsoft.com" target="_blank">stilis@microsoft.com</a>>; <a href="mailto:pavel@labath.sk" target="_blank">pavel@labath.sk</a>; <a href="mailto:mosescu@google.com" target="_blank">mosescu@google.com</a>; <a href="mailto:mgorny@gentoo.org" target="_blank">mgorny@gentoo.org</a>; <a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>; <a href="mailto:llvm@inglorion.net" target="_blank">llvm@inglorion.net</a><br>
<b>Subject:</b> Re: [PATCH] D53002: Create a new symbol file plugin for cross-platform PDB symbolization<u></u><u></u></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_-4318189979030007548m_-6725362069722844241m_-585613557497438892WordSection1">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Oct 10, 2018 at 3:34 PM Stella Stamenova via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal">stella.stamenova added a comment.<br>
<br>
Not sure if you've noticed this yet, but a couple of the new tests are failing on Linux and one of them is failing on Windows as well. The failures on Linux are in disassembly.cpp and source-list.cpp and source-list.cpp is also failing on Windows. Let me know
if you need logs from the failures.<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">It seems none of the bots that run tests currently work, but for an unrelated reason. I wonder if anyone is looking into this? They all complain about a missing FileCheck executable. Since I can't see the Linux failures, I'll have to
wait until tomorrow to reproduce those. I can fix the Windows one (hopefully) by regex'ing out the absolute path.<u></u><u></u></p>
</div>
</div>
</div>
</div></div></blockquote></div>
</blockquote></div>
</blockquote></div>