<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 30, 2018, at 2:32 AM, Roman Lebedev via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: lebedevri<br class="">Date: Thu Aug 30 02:32:09 2018<br class="">New Revision: 341045<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=341045&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=341045&view=rev</a><br class="">Log:<br class="">Revert "[CMake] Use LLVM_ENABLE_IDE instead of CMAKE_CONFIGURATION_TYPES"<br class=""><br class="">That resulted in the check-llvm-* targets not being avaliable<br class="">in the QtCreator-configured build directories.<br class=""><br class="">Moreover, that was a clearly non-NFC change, and i can't find any review<br class="">for it.<br class=""></div></div></blockquote><div><br class=""></div><div>And no discussion on the revert either?</div><div><br class=""></div><div>This wasn't intended to be an NFC change. I apologize if it caused an issue with QtCreator, but a discussion would have been warranted before the revert.</div><div><br class=""></div><div>I've been making lots of non-NFC changes to CMake without review for years, which is consistent with the developer policy (See point #4 <a href="https://www.llvm.org/docs/DeveloperPolicy.html#code-reviews" class="">https://www.llvm.org/docs/DeveloperPolicy.html#code-reviews</a>). This was a fairly small and isolated change. Again, I apologize that it caused you problems.</div><div><br class=""></div><div>The problem this was trying to address is that Visual Studio doesn't handle the target explosion caused by these options well, so using LLVM_ENABLE_IDE to filter them down makes sense. Obviously you care about those targets existing in QTCreator, but are setting LLVM_ENABLE_IDE.</div><div><br class=""></div><div>Are you setting LLVM_ENABLE_IDE deliberately?</div><div><br class=""></div><div>I'd like to come to a solution that works for your needs as well as my own.</div><div><br class=""></div><div>-Chris</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">This reverts commit rL340435.<br class=""><br class="">Modified:<br class=""> llvm/trunk/CMakeLists.txt<br class=""> llvm/trunk/cmake/modules/AddLLVM.cmake<br class=""> llvm/trunk/cmake/modules/CMakeLists.txt<br class=""> llvm/trunk/tools/xcode-toolchain/CMakeLists.txt<br class=""><br class="">Modified: llvm/trunk/CMakeLists.txt<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=341045&r1=341044&r2=341045&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=341045&r1=341044&r2=341045&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/CMakeLists.txt (original)<br class="">+++ llvm/trunk/CMakeLists.txt Thu Aug 30 02:32:09 2018<br class="">@@ -978,7 +978,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)<br class=""> add_custom_target(llvm-headers DEPENDS intrinsics_gen)<br class=""> set_target_properties(llvm-headers PROPERTIES FOLDER "Misc")<br class=""><br class="">- if (NOT LLVM_ENABLE_IDE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES)<br class=""> add_llvm_install_targets(install-llvm-headers<br class=""> DEPENDS llvm-headers<br class=""> COMPONENT llvm-headers)<br class="">@@ -988,7 +988,7 @@ endif()<br class=""> # This must be at the end of the LLVM root CMakeLists file because it must run<br class=""> # after all targets are created.<br class=""> if(LLVM_DISTRIBUTION_COMPONENTS)<br class="">- if(LLVM_ENABLE_IDE)<br class="">+ if(CMAKE_CONFIGURATION_TYPES)<br class=""> message(FATAL_ERROR "LLVM_DISTRIBUTION_COMPONENTS cannot be specified with multi-configuration generators (i.e. Xcode or Visual Studio)")<br class=""> endif()<br class=""><br class=""><br class="">Modified: llvm/trunk/cmake/modules/AddLLVM.cmake<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=341045&r1=341044&r2=341045&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=341045&r1=341044&r2=341045&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/cmake/modules/AddLLVM.cmake (original)<br class="">+++ llvm/trunk/cmake/modules/AddLLVM.cmake Thu Aug 30 02:32:09 2018<br class="">@@ -659,7 +659,7 @@ macro(add_llvm_library name)<br class=""> ${install_type} DESTINATION ${install_dir}<br class=""> COMPONENT ${name})<br class=""><br class="">- if (NOT LLVM_ENABLE_IDE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES)<br class=""> add_llvm_install_targets(install-${name}<br class=""> DEPENDS ${name}<br class=""> COMPONENT ${name})<br class="">@@ -890,7 +890,7 @@ macro(add_llvm_tool name)<br class=""> RUNTIME DESTINATION ${LLVM_TOOLS_INSTALL_DIR}<br class=""> COMPONENT ${name})<br class=""><br class="">- if (NOT LLVM_ENABLE_IDE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES)<br class=""> add_llvm_install_targets(install-${name}<br class=""> DEPENDS ${name}<br class=""> COMPONENT ${name})<br class="">@@ -928,7 +928,7 @@ macro(add_llvm_utility name)<br class=""> install (TARGETS ${name}<br class=""> RUNTIME DESTINATION ${LLVM_UTILS_INSTALL_DIR}<br class=""> COMPONENT ${name})<br class="">- if (NOT LLVM_ENABLE_IDE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES)<br class=""> add_llvm_install_targets(install-${name}<br class=""> DEPENDS ${name}<br class=""> COMPONENT ${name})<br class="">@@ -1390,7 +1390,7 @@ function(add_lit_testsuite target commen<br class=""> endfunction()<br class=""><br class=""> function(add_lit_testsuites project directory)<br class="">- if (NOT LLVM_ENABLE_IDE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES)<br class=""> cmake_parse_arguments(ARG "" "" "PARAMS;DEPENDS;ARGS" ${ARGN})<br class=""><br class=""> # Search recursively for test directories by assuming anything not<br class="">@@ -1449,7 +1449,7 @@ function(llvm_install_library_symlink na<br class=""> CODE "install_symlink(${full_name} ${full_dest} ${output_dir})"<br class=""> COMPONENT ${component})<br class=""><br class="">- if (NOT LLVM_ENABLE_IDE AND NOT ARG_ALWAYS_GENERATE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES AND NOT ARG_ALWAYS_GENERATE)<br class=""> add_llvm_install_targets(install-${name}<br class=""> DEPENDS ${name} ${dest} install-${dest}<br class=""> COMPONENT ${name})<br class="">@@ -1482,7 +1482,7 @@ function(llvm_install_symlink name dest)<br class=""> CODE "install_symlink(${full_name} ${full_dest} ${LLVM_TOOLS_INSTALL_DIR})"<br class=""> COMPONENT ${component})<br class=""><br class="">- if (NOT LLVM_ENABLE_IDE AND NOT ARG_ALWAYS_GENERATE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES AND NOT ARG_ALWAYS_GENERATE)<br class=""> add_llvm_install_targets(install-${name}<br class=""> DEPENDS ${name} ${dest} install-${dest}<br class=""> COMPONENT ${name})<br class=""><br class="">Modified: llvm/trunk/cmake/modules/CMakeLists.txt<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CMakeLists.txt?rev=341045&r1=341044&r2=341045&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CMakeLists.txt?rev=341045&r1=341044&r2=341045&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/cmake/modules/CMakeLists.txt (original)<br class="">+++ llvm/trunk/cmake/modules/CMakeLists.txt Thu Aug 30 02:32:09 2018<br class="">@@ -132,7 +132,7 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)<br class=""> PATTERN LLVM-Config.cmake EXCLUDE<br class=""> PATTERN GetHostTriple.cmake EXCLUDE)<br class=""><br class="">- if (NOT LLVM_ENABLE_IDE)<br class="">+ if (NOT CMAKE_CONFIGURATION_TYPES)<br class=""> # Add a dummy target so this can be used with LLVM_DISTRIBUTION_COMPONENTS<br class=""> add_custom_target(cmake-exports)<br class=""> add_llvm_install_targets(install-cmake-exports<br class=""><br class="">Modified: llvm/trunk/tools/xcode-toolchain/CMakeLists.txt<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/xcode-toolchain/CMakeLists.txt?rev=341045&r1=341044&r2=341045&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/xcode-toolchain/CMakeLists.txt?rev=341045&r1=341044&r2=341045&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/tools/xcode-toolchain/CMakeLists.txt (original)<br class="">+++ llvm/trunk/tools/xcode-toolchain/CMakeLists.txt Thu Aug 30 02:32:09 2018<br class="">@@ -100,7 +100,7 @@ add_llvm_install_targets(install-xcode-t<br class=""> PREFIX ${LLVMToolchainDir}/usr/)<br class=""><br class=""> if(LLVM_DISTRIBUTION_COMPONENTS)<br class="">- if(LLVM_ENABLE_IDE)<br class="">+ if(CMAKE_CONFIGURATION_TYPES)<br class=""> message(FATAL_ERROR "LLVM_DISTRIBUTION_COMPONENTS cannot be specified with multi-configuration generators (i.e. Xcode or Visual Studio)")<br class=""> endif()<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></body></html>