<div dir="ltr">Looks good - thanks!</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 21, 2018 at 1:40 PM George Karpenkov via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL342767: [analyzer] [NFC] Prefer make_unique over "new" (authored by george.karpenkov, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Changed prior to commit:<br>
<a href="https://reviews.llvm.org/D52336?vs=166398&id=166549#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D52336?vs=166398&id=166549#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D52336" rel="noreferrer" target="_blank">https://reviews.llvm.org/D52336</a><br>
<br>
Files:<br>
cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp<br>
<br>
<br>
Index: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp<br>
===================================================================<br>
--- cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp<br>
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp<br>
@@ -750,9 +750,8 @@<br>
}<br>
<br>
assert(BT);<br>
- auto report = std::unique_ptr<BugReport>(<br>
- new CFRefReport(*BT, C.getASTContext().getLangOpts(),<br>
- SummaryLog, N, Sym));<br>
+ auto report = llvm::make_unique<CFRefReport>(<br>
+ *BT, C.getASTContext().getLangOpts(), SummaryLog, N, Sym);<br>
report->addRange(ErrorRange);<br>
C.emitReport(std::move(report));<br>
}<br>
@@ -951,9 +950,9 @@<br>
ExplodedNode *N = C.addTransition(state, Pred, &ReturnOwnLeakTag);<br>
if (N) {<br>
const LangOptions &LOpts = C.getASTContext().getLangOpts();<br>
- C.emitReport(std::unique_ptr<BugReport>(new CFRefLeakReport(<br>
- *getLeakAtReturnBug(LOpts), LOpts,<br>
- SummaryLog, N, Sym, C, IncludeAllocationLine)));<br>
+ C.emitReport(llvm::make_unique<CFRefLeakReport>(<br>
+ *getLeakAtReturnBug(LOpts), LOpts, SummaryLog, N, Sym, C,<br>
+ IncludeAllocationLine));<br>
}<br>
}<br>
}<br>
@@ -978,9 +977,9 @@<br>
if (!returnNotOwnedForOwned)<br>
returnNotOwnedForOwned.reset(new ReturnedNotOwnedForOwned(this));<br>
<br>
- C.emitReport(std::unique_ptr<BugReport>(new CFRefReport(<br>
+ C.emitReport(llvm::make_unique<CFRefReport>(<br>
*returnNotOwnedForOwned, C.getASTContext().getLangOpts(),<br>
- SummaryLog, N, Sym)));<br>
+ SummaryLog, N, Sym));<br>
}<br>
}<br>
}<br>
@@ -1182,9 +1181,8 @@<br>
overAutorelease.reset(new OverAutorelease(this));<br>
<br>
const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();<br>
- Ctx.emitReport(std::unique_ptr<BugReport>(<br>
- new CFRefReport(*overAutorelease, LOpts,<br>
- SummaryLog, N, Sym, os.str())));<br>
+ Ctx.emitReport(llvm::make_unique<CFRefReport>(<br>
+ *overAutorelease, LOpts, SummaryLog, N, Sym, os.str()));<br>
}<br>
<br>
return nullptr;<br>
@@ -1235,9 +1233,8 @@<br>
: getLeakAtReturnBug(LOpts);<br>
assert(BT && "BugType not initialized.");<br>
<br>
- Ctx.emitReport(std::unique_ptr<BugReport>(<br>
- new CFRefLeakReport(*BT, LOpts, SummaryLog, N, *I, Ctx,<br>
- IncludeAllocationLine)));<br>
+ Ctx.emitReport(llvm::make_unique<CFRefLeakReport>(<br>
+ *BT, LOpts, SummaryLog, N, *I, Ctx, IncludeAllocationLine));<br>
}<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>