<div dir="ltr">+zach</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 24, 2018 at 6:00 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What's the purpose of the three question marks here? Are they there to indicate confusion? In which case maybe a more specific description would be suitable (& avoid the trigraph issue)?</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 20, 2018 at 11:27 AM Rui Ueyama via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Thu Sep 20 11:26:38 2018<br>
New Revision: 342674<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342674&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=342674&view=rev</a><br>
Log:<br>
Fix -Wtrigraphs.<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp?rev=342674&r1=342673&r2=342674&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp?rev=342674&r1=342673&r2=342674&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp (original)<br>
+++ llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp Thu Sep 20 11:26:38 2018<br>
@@ -41,7 +41,7 @@ static std::string formatClassOptions(ui<br>
         Stream->findFullDeclForForwardRef(CurrentTypeIndex);<br>
     if (!ETI) {<br>
       consumeError(ETI.takeError());<br>
-      PUSH_FLAG(ClassOptions, ForwardReference, Options, "forward ref (???)");<br>
+      PUSH_FLAG(ClassOptions, ForwardReference, Options, "forward ref (??\?)");<br>
     } else {<br>
       const char *Direction = (*ETI == CurrentTypeIndex)<br>
                                   ? "="<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>