<div dir="ltr">Any chance of a unit test?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 21, 2018 at 4:01 PM Lang Hames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Fri Sep 21 15:59:48 2018<br>
New Revision: 342783<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342783&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=342783&view=rev</a><br>
Log:<br>
[ORC] In RTDyldObjectLinkingLayer, only call NotifyFreed if the object file<br>
has been finalized.<br>
<br>
This prevents crashes on unfinalized objects for clients using<br>
JITEventListeners.<br>
<br>
Patch by Geoff Levner. Thanks Geoff!<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h<br>
<br>
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h?rev=342783&r1=342782&r2=342783&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h?rev=342783&r1=342782&r2=342783&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h (original)<br>
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h Fri Sep 21 15:59:48 2018<br>
@@ -203,7 +203,7 @@ private:<br>
     }<br>
<br>
     ~ConcreteLinkedObject() override {<br>
-      if (this->Parent.NotifyFreed)<br>
+      if (this->Parent.NotifyFreed && ObjForNotify.getBinary())<br>
         this->Parent.NotifyFreed(K, *ObjForNotify.getBinary());<br>
<br>
       MemMgr->deregisterEHFrames();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>