<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 20, 2018, at 3:05 PM, Leonard Mosescu <<a href="mailto:mosescu@google.com" class="">mosescu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">Hi Greg, looking at request_evaluate() I noticed that it will evaluate the string as a lldb command if prefixed by ` . </div><div dir="ltr" class=""><br class=""></div><div dir="ltr" class="">This is a great feature (it allows building REPL consoles on top of DAP), but I'm curious how you picked up this convention? For example I believe that the gdb DAP uses -exec 'command' instead.</div></div></div></blockquote><div><br class=""></div>` is an illegal expression character so it won't stop you from evaluating any possible expression. The gdb prefix "-exec" stops you from being able to negate a local variable named "exec". Not a huge deal. So I just picked a good prefix character that wouldn't stop anyone from evaluating any valid expression (at least in C/C++/ObjC/Swift).</div><div><br class=""></div><div>The solution I would love to see is to have the initialize packet return something via the DAP that says "I have a command line interpreter, please send a packet with a file handle (slave path to slave side of pseudo terminal maybe)". VS Code and Nuclide both emulated tty already, so we could have a true command line that exposes the "(gdb)" prompt for GDB and "(lldb)" for lldb and all the power that comes with it. </div><div><br class=""></div><div>I needed something that could run LLDB commands when things go wrong to do trouble shooting (enable logging, run commands to dump vital information) so I hacked it in with `</div><div><br class=""></div><div>Greg</div><div><br class=""></div><div><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Aug 16, 2018 at 11:01 AM, Phabricator via Phabricator <span dir="ltr" class=""><<a href="mailto:reviews@reviews.llvm.org" target="_blank" class="">reviews@reviews.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br class="">
Closed by commit rL339911: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug… (authored by gclayton, committed by ).<br class="">
Herald added a subscriber: llvm-commits.<br class="">
<br class="">
Changed prior to commit:<br class="">
<a href="https://reviews.llvm.org/D50365?vs=161058&id=161067#toc" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D50365?vs=161058&id=161067#toc</a><br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://reviews.llvm.org/D50365" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D50365</a><br class="">
<br class="">
Files:<br class="">
lldb/trunk/lldb.xcodeproj/<wbr class="">project.pbxproj<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/dotest.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/lldbtest.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/.categories<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/attach/Makefile<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/attach/TestVSCode_<wbr class="">attach.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/attach/main.c<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/breakpoint/Makefile<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/breakpoint/TestVSCode_<wbr class="">setBreakpoints.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/breakpoint/TestVSCode_<wbr class="">setExceptionBreakpoints.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/breakpoint/TestVSCode_<wbr class="">setFunctionBreakpoints.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/breakpoint/main.cpp<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/launch/Makefile<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/launch/TestVSCode_<wbr class="">launch.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/launch/main.c<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/lldbvscode_testcase.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/stackTrace/Makefile<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/stackTrace/TestVSCode_<wbr class="">stackTrace.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/stackTrace/main.c<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/step/Makefile<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/step/TestVSCode_step.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/step/main.cpp<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/variables/Makefile<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/variables/TestVSCode_<wbr class="">variables.py<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/variables/main.cpp<br class="">
lldb/trunk/packages/Python/<wbr class="">lldbsuite/test/tools/lldb-<wbr class="">vscode/vscode.py<br class="">
lldb/trunk/tools/CMakeLists.<wbr class="">txt<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">BreakpointBase.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">BreakpointBase.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">CMakeLists.txt<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">ExceptionBreakpoint.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">ExceptionBreakpoint.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">FunctionBreakpoint.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">FunctionBreakpoint.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">JSONUtils.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">JSONUtils.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">LLDBUtils.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">LLDBUtils.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">README.md<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">SourceBreakpoint.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">SourceBreakpoint.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">SourceReference.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">VSCode.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">VSCode.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">VSCodeForward.h<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">lldb-vscode-Info.plist<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">lldb-vscode.cpp<br class="">
lldb/trunk/tools/lldb-vscode/<wbr class="">package.json<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>