<div dir="ltr"><div dir="ltr">Hi Greg, looking at request_evaluate() I noticed that it will evaluate the string as a lldb command if prefixed by ` . </div><div dir="ltr"><br></div><div dir="ltr">This is a great feature (it allows building REPL consoles on top of DAP), but I'm curious how you picked up this convention? For example I believe that the gdb DAP uses -exec 'command' instead.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 16, 2018 at 11:01 AM, Phabricator via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL339911: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug… (authored by gclayton, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Changed prior to commit:<br>
<a href="https://reviews.llvm.org/D50365?vs=161058&id=161067#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D50365?vs=161058&id=161067#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D50365" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D50365</a><br>
<br>
Files:<br>
lldb/trunk/lldb.xcodeproj/<wbr>project.pbxproj<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/dotest.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/lldbtest.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/.categories<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/attach/Makefile<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/attach/TestVSCode_<wbr>attach.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/attach/main.c<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/breakpoint/Makefile<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/breakpoint/TestVSCode_<wbr>setBreakpoints.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/breakpoint/TestVSCode_<wbr>setExceptionBreakpoints.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/breakpoint/TestVSCode_<wbr>setFunctionBreakpoints.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/breakpoint/main.cpp<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/launch/Makefile<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/launch/TestVSCode_<wbr>launch.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/launch/main.c<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/lldbvscode_testcase.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/stackTrace/Makefile<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/stackTrace/TestVSCode_<wbr>stackTrace.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/stackTrace/main.c<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/step/Makefile<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/step/TestVSCode_step.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/step/main.cpp<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/variables/Makefile<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/variables/TestVSCode_<wbr>variables.py<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/variables/main.cpp<br>
lldb/trunk/packages/Python/<wbr>lldbsuite/test/tools/lldb-<wbr>vscode/vscode.py<br>
lldb/trunk/tools/CMakeLists.<wbr>txt<br>
lldb/trunk/tools/lldb-vscode/<wbr>BreakpointBase.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>BreakpointBase.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>CMakeLists.txt<br>
lldb/trunk/tools/lldb-vscode/<wbr>ExceptionBreakpoint.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>ExceptionBreakpoint.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>FunctionBreakpoint.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>FunctionBreakpoint.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>JSONUtils.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>JSONUtils.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>LLDBUtils.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>LLDBUtils.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>README.md<br>
lldb/trunk/tools/lldb-vscode/<wbr>SourceBreakpoint.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>SourceBreakpoint.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>SourceReference.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>VSCode.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>VSCode.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>VSCodeForward.h<br>
lldb/trunk/tools/lldb-vscode/<wbr>lldb-vscode-Info.plist<br>
lldb/trunk/tools/lldb-vscode/<wbr>lldb-vscode.cpp<br>
lldb/trunk/tools/lldb-vscode/<wbr>package.json<br>
<br>
</blockquote></div><br></div>