<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi,<div><br></div><div>this is failing on the bot:</div><div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/15732/steps/test%20standalone%20compiler-rt/logs/stdio">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/15732/steps/test%20standalone%20compiler-rt/logs/stdio</a><br></div><div><br></div><div><pre style="font-family:"Courier New",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium;text-decoration-style:initial;text-decoration-color:initial"><span class="gmail-stdout" style="font-family:"Courier New",courier,monotype,monospace;color:black">clang-8: error: /b/sanitizer-x86_64-linux/build/llvm_build64/include: 'linker' input unused [-Werror,-Wunused-command-line-argument]
</span></pre><br class="gmail-Apple-interchange-newline">The compiler (with -c flag) command line includes the path mentioned above without -I .</div><div>I'm not sure how that happens, but reverting this change (along with another one that depends on it) helps.</div><div><br></div><div><br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 18, 2018 at 4:59 PM, Dean Michael Berris via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">Author: dberris<br>
Date: Tue Sep 18 16:59:32 2018<br>
New Revision: 342518<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342518&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=342518&view=rev</a><br>
Log:<br>
[XRay][compiler-rt] FDRLogWriter Abstraction<br>
<br>
Summary:<br>
This change introduces an `FDRLogWriter` type which is responsible for<br>
serialising metadata and function records to character buffers. This is<br>
the first step in a refactoring of the implementation of the FDR runtime<br>
to allow for more granular testing of the individual components of the<br>
implementation.<br>
<br>
The main contribution of this change is a means of hiding the details of<br>
how specific records are written to a buffer, and for managing the<br>
extents of these buffers. We make use of C++ features (templates and<br>
some metaprogramming) to reduce repetition in the act of writing out<br>
specific kinds of records to the buffer.<br>
<br>
In this process, we make a number of changes across both LLVM and<br>
compiler-rt to allow us to use the `Trace` abstraction defined in the<br>
LLVM project in the testing of the runtime implementation. This gives us<br>
a closer end-to-end test which version-locks the runtime implementation<br>
with the loading implementation in LLVM.<br>
<br>
We also allow using gmock in compiler-rt unit tests, by adding the<br>
requisite definitions in the `AddCompilerRT.cmake` module.<br>
<br>
Finally, we've gone ahead and updated the FDR logging implementation to<br>
use the FDRLogWriter for the lowest-level record-writing details.<br>
<br>
Following patches will isolate the state machine transitions which<br>
manage the set-up and tear-down of the buffers we're using in multiple<br>
threads.<br>
<br>
Reviewers: mboerger, eizan<br>
<br>
Subscribers: mgorny, jfb, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D52220" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D52220</a><br>
<br>
</div></div>Modified:<br>
llvm/trunk/include/llvm/XRay/<wbr>Trace.h<br>
<br>
Modified: llvm/trunk/include/llvm/XRay/<wbr>Trace.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/XRay/Trace.h?rev=342518&r1=342517&r2=342518&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/XRay/Trace.h?rev=342518&<wbr>r1=342517&r2=342518&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/XRay/<wbr>Trace.h (original)<br>
+++ llvm/trunk/include/llvm/XRay/<wbr>Trace.h Tue Sep 18 16:59:32 2018<br>
@@ -46,20 +46,25 @@ namespace xray {<br>
///<br>
class Trace {<br>
XRayFileHeader FileHeader;<br>
- std::vector<XRayRecord> Records;<br>
+ using RecordVector = std::vector<XRayRecord>;<br>
+ RecordVector Records;<br>
<br>
typedef std::vector<XRayRecord>::<wbr>const_iterator citerator;<br>
<br>
friend Expected<Trace> loadTrace(const DataExtractor &, bool);<br>
<br>
public:<br>
+ using size_type = RecordVector::size_type;<br>
+ using value_type = RecordVector::value_type;<br>
+ using const_iterator = RecordVector::const_iterator;<br>
+<br>
/// Provides access to the loaded XRay trace file header.<br>
const XRayFileHeader &getFileHeader() const { return FileHeader; }<br>
<br>
- citerator begin() const { return Records.begin(); }<br>
- citerator end() const { return Records.end(); }<br>
+ const_iterator begin() const { return Records.begin(); }<br>
+ const_iterator end() const { return Records.end(); }<br>
bool empty() const { return Records.empty(); }<br>
- size_t size() const { return Records.size(); }<br>
+ size_type size() const { return Records.size(); }<br>
};<br>
<br>
/// This function will attempt to load XRay trace records from the provided<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>