<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks Reid, I’ll take a look.<div class=""><br class=""></div><div class="">Amara<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 14, 2018, at 9:00 PM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I got this reduction:<div class=""><pre id="gmail-hterm:copy-to-clipboard-source" style="" class="">$ cat geometry.cpp
typedef float a __attribute__((__vector_size__(16)));
a b();
float c();
struct d {
float e;
float f;
};
struct g {
g(float) : h(b()) {}
void i(void *j) {
__builtin_ia32_storelps(
(__attribute__((__vector_size__(8))) int *)j, h);
}
a h;
};
d k(g j) {
d l;
j.i(&l);
return l;
}
bool m;
float n;
struct o {
d p[];
void q(o[]) const;
};
void o::q(o *j) const {
d r = k(n);
if (m)
r.e = c();
j[0].p[1] = k(0);
j[1].p[0] = r;
}
$ ./bin/clang++ -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -target-cpu x86-64 -O2 geometry.cpp |& head
clang++: /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/CodeGen/ValueTypes.h:274: unsigned int llvm::EVT::getVectorNumElements() const: Assertion `isVector() && "Invalid vector type!"' failed.</pre></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Sep 14, 2018 at 12:41 PM Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">I reverted this in r<span style="" class="">342265 because it caused assertion failures while building Chromium. I'm starting a reduction.</span></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Sep 13, 2018 at 2:30 PM Amara Emerson via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aemerson<br class="">
Date: Thu Sep 13 14:28:58 2018<br class="">
New Revision: 342183<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342183&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=342183&view=rev</a><br class="">
Log:<br class="">
[DAGCombine] Fix crash when store merging created an extract_subvector with invalid index.<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D51831" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D51831</a><br class="">
<br class="">
Added:<br class="">
llvm/trunk/test/CodeGen/X86/merge-vector-stores-scale-idx-crash.ll<br class="">
Modified:<br class="">
llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=342183&r1=342182&r2=342183&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=342183&r1=342182&r2=342183&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)<br class="">
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Thu Sep 13 14:28:58 2018<br class="">
@@ -13843,17 +13843,24 @@ bool DAGCombiner::MergeStoresOfConstants<br class="">
Val.getOpcode() == ISD::EXTRACT_SUBVECTOR)) {<br class="">
SDValue Vec = Val.getOperand(0);<br class="">
EVT MemVTScalarTy = MemVT.getScalarType();<br class="">
+ SDValue Idx = Val.getOperand(1);<br class="">
// We may need to add a bitcast here to get types to line up.<br class="">
if (MemVTScalarTy != Vec.getValueType()) {<br class="">
unsigned Elts = Vec.getValueType().getSizeInBits() /<br class="">
MemVTScalarTy.getSizeInBits();<br class="">
+ if (Val.getValueType().isVector()) {<br class="">
+ unsigned IdxC = cast<ConstantSDNode>(Idx)->getZExtValue();<br class="">
+ unsigned NewIdx =<br class="">
+ ((uint64_t)IdxC * MemVT.getVectorNumElements()) / Elts;<br class="">
+ Idx = DAG.getConstant(NewIdx, SDLoc(Val), Idx.getValueType());<br class="">
+ }<br class="">
EVT NewVecTy =<br class="">
EVT::getVectorVT(*DAG.getContext(), MemVTScalarTy, Elts);<br class="">
Vec = DAG.getBitcast(NewVecTy, Vec);<br class="">
}<br class="">
auto OpC = (MemVT.isVector()) ? ISD::EXTRACT_SUBVECTOR<br class="">
: ISD::EXTRACT_VECTOR_ELT;<br class="">
- Val = DAG.getNode(OpC, SDLoc(Val), MemVT, Vec, Val.getOperand(1));<br class="">
+ Val = DAG.getNode(OpC, SDLoc(Val), MemVT, Vec, Idx);<br class="">
}<br class="">
Ops.push_back(Val);<br class="">
}<br class="">
<br class="">
Added: llvm/trunk/test/CodeGen/X86/merge-vector-stores-scale-idx-crash.ll<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/merge-vector-stores-scale-idx-crash.ll?rev=342183&view=auto" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/merge-vector-stores-scale-idx-crash.ll?rev=342183&view=auto</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/test/CodeGen/X86/merge-vector-stores-scale-idx-crash.ll (added)<br class="">
+++ llvm/trunk/test/CodeGen/X86/merge-vector-stores-scale-idx-crash.ll Thu Sep 13 14:28:58 2018<br class="">
@@ -0,0 +1,19 @@<br class="">
+; RUN: llc < %s -mtriple=x86_64-apple-osx10.14 -mattr=+avx2 | FileCheck %s<br class="">
+<br class="">
+; Check that we don't crash due creating invalid extract_subvector indices in store merging.<br class="">
+; CHECK-LABEL: testfn<br class="">
+; CHECK: retq<br class="">
+define void @testfn(i32* nocapture %p) {<br class="">
+ %v0 = getelementptr i32, i32* %p, i64 12<br class="">
+ %1 = bitcast i32* %v0 to <2 x i64>*<br class="">
+ %2 = bitcast i32* %v0 to <4 x i32>*<br class="">
+ %3 = getelementptr <2 x i64>, <2 x i64>* %1, i64 -3<br class="">
+ store <2 x i64> undef, <2 x i64>* %3, align 16<br class="">
+ %4 = shufflevector <4 x i64> zeroinitializer, <4 x i64> undef, <2 x i32> <i32 0, i32 1><br class="">
+ %5 = getelementptr <2 x i64>, <2 x i64>* %1, i64 -2<br class="">
+ store <2 x i64> %4, <2 x i64>* %5, align 16<br class="">
+ %6 = shufflevector <8 x i32> zeroinitializer, <8 x i32> undef, <4 x i32> <i32 4, i32 5, i32 6, i32 7><br class="">
+ %7 = getelementptr <4 x i32>, <4 x i32>* %2, i64 -1<br class="">
+ store <4 x i32> %6, <4 x i32>* %7, align 16<br class="">
+ ret void<br class="">
+}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>