<div dir="ltr"><div>I think this should be reverted because it's breaking all the bots with errors like this:</div><div><pre><span class="gmail-stderr">/Users/buildslave/as-bldslv9/lld-x86_64-darwin13/llvm.src/include/llvm/IR/Attributes.h:74:14: fatal error: 'llvm/IR/Attributes.inc' file not found
    #include "llvm/IR/Attributes.inc"
</span></pre><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 13, 2018 at 10:33 AM, Roman Lebedev via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It is a good idea to actually supply a commit message.<br>
Why is this change needed? There is no reasoning/explanation at all.<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Sep 13, 2018 at 7:15 PM, Richard Diamond via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: diamond<br>
> Date: Thu Sep 13 09:15:03 2018<br>
> New Revision: 342148<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342148&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=342148&view=rev</a><br>
> Log:<br>
> Renovate CMake files in the `llvm-(cfi-verify|exegesis|<wbr>mca)` tools.<br>
><br>
> Modified:<br>
>     llvm/trunk/tools/llvm-cfi-<wbr>verify/lib/CMakeLists.txt<br>
>     llvm/trunk/tools/llvm-<wbr>exegesis/lib/AArch64/<wbr>CMakeLists.txt<br>
>     llvm/trunk/tools/llvm-<wbr>exegesis/lib/CMakeLists.txt<br>
>     llvm/trunk/tools/llvm-<wbr>exegesis/lib/X86/CMakeLists.<wbr>txt<br>
>     llvm/trunk/tools/llvm-mca/lib/<wbr>CMakeLists.txt<br>
><br>
> Modified: llvm/trunk/tools/llvm-cfi-<wbr>verify/lib/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cfi-verify/lib/CMakeLists.txt?rev=342148&r1=342147&r2=342148&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>cfi-verify/lib/CMakeLists.txt?<wbr>rev=342148&r1=342147&r2=<wbr>342148&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-cfi-<wbr>verify/lib/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-cfi-<wbr>verify/lib/CMakeLists.txt Thu Sep 13 09:15:03 2018<br>
> @@ -1,13 +1,12 @@<br>
> -add_library(LLVMCFIVerify<br>
> -  STATIC<br>
> +add_llvm_library(<wbr>LLVMCFIVerify<br>
>    FileAnalysis.cpp<br>
>    FileAnalysis.h<br>
>    GraphBuilder.cpp<br>
>    GraphBuilder.h<br>
> -  )<br>
><br>
> -llvm_update_compile_flags(<wbr>LLVMCFIVerify)<br>
> -llvm_map_components_to_<wbr>libnames(libs<br>
> +  STATIC<br>
> +<br>
> +  LINK_COMPONENTS<br>
>    DebugInfoDWARF<br>
>    MC<br>
>    MCParser<br>
> @@ -15,5 +14,3 @@ llvm_map_components_to_<wbr>libnames(libs<br>
>    Support<br>
>    Symbolize<br>
>    )<br>
> -target_link_libraries(<wbr>LLVMCFIVerify ${libs})<br>
> -set_target_properties(<wbr>LLVMCFIVerify PROPERTIES FOLDER "Libraries")<br>
><br>
> Modified: llvm/trunk/tools/llvm-<wbr>exegesis/lib/AArch64/<wbr>CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/AArch64/CMakeLists.txt?rev=342148&r1=342147&r2=342148&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>exegesis/lib/AArch64/<wbr>CMakeLists.txt?rev=342148&r1=<wbr>342147&r2=342148&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-<wbr>exegesis/lib/AArch64/<wbr>CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-<wbr>exegesis/lib/AArch64/<wbr>CMakeLists.txt Thu Sep 13 09:15:03 2018<br>
> @@ -3,16 +3,12 @@ include_directories(<br>
>    ${LLVM_BINARY_DIR}/lib/Target/<wbr>AArch64<br>
>    )<br>
><br>
> -add_library(<wbr>LLVMExegesisAArch64<br>
> -  STATIC<br>
> +add_llvm_library(<wbr>LLVMExegesisAArch64<br>
>    Target.cpp<br>
> -  )<br>
><br>
> -llvm_update_compile_flags(<wbr>LLVMExegesisAArch64)<br>
> -llvm_map_components_to_<wbr>libnames(libs<br>
> +  STATIC<br>
> +<br>
> +  LINK_COMPONENTS<br>
>    AArch64<br>
>    Exegesis<br>
>    )<br>
> -<br>
> -target_link_libraries(<wbr>LLVMExegesisAArch64 ${libs})<br>
> -set_target_properties(<wbr>LLVMExegesisAArch64 PROPERTIES FOLDER "Libraries")<br>
><br>
> Modified: llvm/trunk/tools/llvm-<wbr>exegesis/lib/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/CMakeLists.txt?rev=342148&r1=342147&r2=342148&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>exegesis/lib/CMakeLists.txt?<wbr>rev=342148&r1=342147&r2=<wbr>342148&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-<wbr>exegesis/lib/CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-<wbr>exegesis/lib/CMakeLists.txt Thu Sep 13 09:15:03 2018<br>
> @@ -7,8 +7,12 @@ if (LLVM_TARGETS_TO_BUILD MATCHES "AArch<br>
>    set(LLVM_EXEGESIS_TARGETS "${LLVM_EXEGESIS_TARGETS} AArch64" PARENT_SCOPE)<br>
>  endif()<br>
><br>
> -add_library(LLVMExegesis<br>
> -  STATIC<br>
> +set(libs)<br>
> +if(LLVM_ENABLE_LIBPFM AND HAVE_LIBPFM)<br>
> +  list(APPEND libs pfm)<br>
> +endif()<br>
> +<br>
> +add_llvm_library(LLVMExegesis<br>
>    Analysis.cpp<br>
>    Assembler.cpp<br>
>    BenchmarkResult.cpp<br>
> @@ -22,10 +26,10 @@ add_library(LLVMExegesis<br>
>    SnippetGenerator.cpp<br>
>    Target.cpp<br>
>    Uops.cpp<br>
> -  )<br>
><br>
> -llvm_update_compile_flags(<wbr>LLVMExegesis)<br>
> -llvm_map_components_to_<wbr>libnames(libs<br>
> +  STATIC<br>
> +<br>
> +  LINK_COMPONENTS<br>
>    Analysis<br>
>    CodeGen<br>
>    Core<br>
> @@ -37,11 +41,6 @@ llvm_map_components_to_<wbr>libnames(libs<br>
>    Object<br>
>    ObjectYAML<br>
>    Support<br>
> -  )<br>
><br>
> -if(LLVM_ENABLE_LIBPFM AND HAVE_LIBPFM)<br>
> -  list(APPEND libs pfm)<br>
> -endif()<br>
> -<br>
> -target_link_libraries(<wbr>LLVMExegesis ${libs})<br>
> -set_target_properties(<wbr>LLVMExegesis PROPERTIES FOLDER "Libraries")<br>
> +  LINK_LIBS ${libs}<br>
> +  )<br>
><br>
> Modified: llvm/trunk/tools/llvm-<wbr>exegesis/lib/X86/CMakeLists.<wbr>txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-exegesis/lib/X86/CMakeLists.txt?rev=342148&r1=342147&r2=342148&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>exegesis/lib/X86/CMakeLists.<wbr>txt?rev=342148&r1=342147&r2=<wbr>342148&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-<wbr>exegesis/lib/X86/CMakeLists.<wbr>txt (original)<br>
> +++ llvm/trunk/tools/llvm-<wbr>exegesis/lib/X86/CMakeLists.<wbr>txt Thu Sep 13 09:15:03 2018<br>
> @@ -3,16 +3,12 @@ include_directories(<br>
>    ${LLVM_BINARY_DIR}/lib/Target/<wbr>X86<br>
>    )<br>
><br>
> -add_library(LLVMExegesisX86<br>
> -  STATIC<br>
> +add_llvm_library(<wbr>LLVMExegesisX86<br>
>    Target.cpp<br>
> -  )<br>
><br>
> -llvm_update_compile_flags(<wbr>LLVMExegesisX86)<br>
> -llvm_map_components_to_<wbr>libnames(libs<br>
> +  STATIC<br>
> +<br>
> +  LINK_COMPONENTS<br>
>    X86<br>
>    Exegesis<br>
>    )<br>
> -<br>
> -target_link_libraries(<wbr>LLVMExegesisX86 ${libs})<br>
> -set_target_properties(<wbr>LLVMExegesisX86 PROPERTIES FOLDER "Libraries")<br>
><br>
> Modified: llvm/trunk/tools/llvm-mca/lib/<wbr>CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/lib/CMakeLists.txt?rev=342148&r1=342147&r2=342148&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>mca/lib/CMakeLists.txt?rev=<wbr>342148&r1=342147&r2=342148&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-mca/lib/<wbr>CMakeLists.txt (original)<br>
> +++ llvm/trunk/tools/llvm-mca/lib/<wbr>CMakeLists.txt Thu Sep 13 09:15:03 2018<br>
> @@ -1,7 +1,6 @@<br>
>  include_directories(${LLVM_<wbr>MCA_SOURCE_DIR}/include)<br>
><br>
> -add_library(LLVMMCA<br>
> -  STATIC<br>
> +add_llvm_library(LLVMMCA<br>
>    Context.cpp<br>
>    HWEventListener.cpp<br>
>    HardwareUnits/HardwareUnit.cpp<br>
> @@ -20,14 +19,11 @@ add_library(LLVMMCA<br>
>    Stages/RetireStage.cpp<br>
>    Stages/Stage.cpp<br>
>    Support.cpp<br>
> -  )<br>
><br>
> -llvm_update_compile_flags(<wbr>LLVMMCA)<br>
> -llvm_map_components_to_<wbr>libnames(libs<br>
> +  STATIC<br>
> +<br>
> +  LINK_COMPONENTS<br>
>    CodeGen<br>
>    MC<br>
>    Support<br>
>    )<br>
> -<br>
> -target_link_libraries(LLVMMCA ${libs})<br>
> -set_target_properties(LLVMMCA PROPERTIES FOLDER "Libraries")<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>