<div dir="ltr">Also it doesn't look like this code was reviewed - could you revert it?<br><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 9, 2018 at 11:29 AM David Carlier via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: devnexen<br>
Date: Thu Aug  9 11:29:07 2018<br>
New Revision: 339367<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=339367&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=339367&view=rev</a><br>
Log:<br>
Fix few g++ 8 warning with non obvious copy object operations<br>
<br>
Reviewers: dblaikie, dexonsmith <br>
<br>
Reviewed By: dblaikie<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D50296" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50296</a><br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/DenseMap.h<br>
    llvm/trunk/include/llvm/ADT/SmallVector.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/DenseMap.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=339367&r1=339366&r2=339367&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=339367&r1=339366&r2=339367&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/DenseMap.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/DenseMap.h Thu Aug  9 11:29:07 2018<br>
@@ -393,7 +393,7 @@ protected:<br>
     setNumTombstones(other.getNumTombstones());<br>
<br>
     if (isPodLike<KeyT>::value && isPodLike<ValueT>::value)<br>
-      memcpy(getBuckets(), other.getBuckets(),<br>
+      memcpy(reinterpret_cast<void *>(getBuckets()), other.getBuckets(),<br>
              getNumBuckets() * sizeof(BucketT));<br>
     else<br>
       for (size_t i = 0; i < getNumBuckets(); ++i) {<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/SmallVector.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/SmallVector.h?rev=339367&r1=339366&r2=339367&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/SmallVector.h?rev=339367&r1=339366&r2=339367&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/SmallVector.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/SmallVector.h Thu Aug  9 11:29:07 2018<br>
@@ -299,7 +299,7 @@ protected:<br>
     // use memcpy here. Note that I and E are iterators and thus might be<br>
     // invalid for memcpy if they are equal.<br>
     if (I != E)<br>
-      memcpy(Dest, I, (E - I) * sizeof(T));<br>
+      memcpy(reinterpret_cast<void *>(Dest), I, (E - I) * sizeof(T));<br>
   }<br>
<br>
   /// Double the size of the allocated memory, guaranteeing space for at<br>
@@ -310,7 +310,7 @@ public:<br>
   void push_back(const T &Elt) {<br>
     if (LLVM_UNLIKELY(this->size() >= this->capacity()))<br>
       this->grow();<br>
-    memcpy(this->end(), &Elt, sizeof(T));<br>
+    memcpy(reinterpret_cast<void *>(this->end()), &Elt, sizeof(T));<br>
     this->set_size(this->size() + 1);<br>
   }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>