<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 13, 2018 at 3:48 PM Tom Stellard <<a href="mailto:tstellar@redhat.com">tstellar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 09/13/2018 03:36 PM, David Blaikie via llvm-commits wrote:<br>
> Also it doesn't look like this code was reviewed - could you revert it?<br>
> <br>
<br>
This is what I thought too, but I realized I had commented on the<br>
the actual commit: <a href="https://reviews.llvm.org/rL339367" rel="noreferrer" target="_blank">https://reviews.llvm.org/rL339367</a> and not<br>
the phabricator review: <a href="https://reviews.llvm.org/D50296" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50296</a>.  According<br>
to the phabricator review you did review the patch.<br></blockquote><div><br>Ah, indeed - just bad reading on my part. Sorry about that.<br><br>Tom - while the bug's being discussed/resolved, would you prefer this be reverted? I don't have a strong opinion either way really.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
-Tom<br>
<br>
> On Thu, Aug 9, 2018 at 11:29 AM David Carlier via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>> wrote:<br>
> <br>
>  Â  Â Author: devnexen<br>
>  Â  Â Date: Thu Aug  9 11:29:07 2018<br>
>  Â  Â New Revision: 339367<br>
> <br>
>  Â  Â URL: <a href="http://llvm.org/viewvc/llvm-project?rev=339367&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=339367&view=rev</a><br>
>  Â  Â Log:<br>
>  Â  Â Fix few g++ 8 warning with non obvious copy object operations<br>
> <br>
>  Â  Â Reviewers: dblaikie, dexonsmith<br>
> <br>
>  Â  Â Reviewed By: dblaikie<br>
> <br>
>  Â  Â Differential Revision: <a href="https://reviews.llvm.org/D50296" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50296</a><br>
> <br>
>  Â  Â Modified:<br>
>  Â  Â  Â  Â llvm/trunk/include/llvm/ADT/DenseMap.h<br>
>  Â  Â  Â  Â llvm/trunk/include/llvm/ADT/SmallVector.h<br>
> <br>
>  Â  Â Modified: llvm/trunk/include/llvm/ADT/DenseMap.h<br>
>  Â  Â URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=339367&r1=339366&r2=339367&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=339367&r1=339366&r2=339367&view=diff</a><br>
>  Â  Â ==============================================================================<br>
>  Â  Â --- llvm/trunk/include/llvm/ADT/DenseMap.h (original)<br>
>  Â  Â +++ llvm/trunk/include/llvm/ADT/DenseMap.h Thu Aug  9 11:29:07 2018<br>
>  Â  Â @@ -393,7 +393,7 @@ protected:<br>
>  Â  Â  Â  Â  setNumTombstones(other.getNumTombstones());<br>
> <br>
>  Â  Â  Â  Â  if (isPodLike<KeyT>::value && isPodLike<ValueT>::value)<br>
>  Â  Â -  Â  Â  memcpy(getBuckets(), other.getBuckets(),<br>
>  Â  Â +  Â  Â  memcpy(reinterpret_cast<void *>(getBuckets()), other.getBuckets(),<br>
>  Â  Â  Â  Â  Â  Â  Â  Â  Â getNumBuckets() * sizeof(BucketT));<br>
>  Â  Â  Â  Â  else<br>
>  Â  Â  Â  Â  Â  for (size_t i = 0; i < getNumBuckets(); ++i) {<br>
> <br>
>  Â  Â Modified: llvm/trunk/include/llvm/ADT/SmallVector.h<br>
>  Â  Â URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/SmallVector.h?rev=339367&r1=339366&r2=339367&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/SmallVector.h?rev=339367&r1=339366&r2=339367&view=diff</a><br>
>  Â  Â ==============================================================================<br>
>  Â  Â --- llvm/trunk/include/llvm/ADT/SmallVector.h (original)<br>
>  Â  Â +++ llvm/trunk/include/llvm/ADT/SmallVector.h Thu Aug  9 11:29:07 2018<br>
>  Â  Â @@ -299,7 +299,7 @@ protected:<br>
>  Â  Â  Â  Â  // use memcpy here. Note that I and E are iterators and thus might be<br>
>  Â  Â  Â  Â  // invalid for memcpy if they are equal.<br>
>  Â  Â  Â  Â  if (I != E)<br>
>  Â  Â -  Â  Â  memcpy(Dest, I, (E - I) * sizeof(T));<br>
>  Â  Â +  Â  Â  memcpy(reinterpret_cast<void *>(Dest), I, (E - I) * sizeof(T));<br>
>  Â  Â  Â  }<br>
> <br>
>  Â  Â  Â  /// Double the size of the allocated memory, guaranteeing space for at<br>
>  Â  Â @@ -310,7 +310,7 @@ public:<br>
>  Â  Â  Â  void push_back(const T &Elt) {<br>
>  Â  Â  Â  Â  if (LLVM_UNLIKELY(this->size() >= this->capacity()))<br>
>  Â  Â  Â  Â  Â  this->grow();<br>
>  Â  Â -  Â  memcpy(this->end(), &Elt, sizeof(T));<br>
>  Â  Â +  Â  memcpy(reinterpret_cast<void *>(this->end()), &Elt, sizeof(T));<br>
>  Â  Â  Â  Â  this->set_size(this->size() + 1);<br>
>  Â  Â  Â  }<br>
> <br>
> <br>
> <br>
>  Â  Â _______________________________________________<br>
>  Â  Â llvm-commits mailing list<br>
>  Â  Â <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
>  Â  Â <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> <br>
<br>
</blockquote></div></div>