LGTM<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 5, 2018, 3:41 PM Ivan Lozano via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ivanlozano updated this revision to Diff 164116.<br>
ivanlozano marked an inline comment as done.<br>
ivanlozano added a comment.<br>
<br>
Added additional comments to clarify to the source code additions.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D48792" rel="noreferrer" target="_blank">https://reviews.llvm.org/D48792</a><br>
<br>
Files:<br>
  include/llvm/MC/MCELFObjectWriter.h<br>
  include/llvm/MC/MCSection.h<br>
  lib/MC/ELFObjectWriter.cpp<br>
  lib/MC/MCELFObjectTargetWriter.cpp<br>
  lib/MC/MCObjectStreamer.cpp<br>
  lib/MC/MCSection.cpp<br>
  lib/Target/ARM/ARMTargetObjectFile.cpp<br>
  lib/Target/ARM/MCTargetDesc/ARMELFObjectWriter.cpp<br>
  test/CodeGen/ARM/execute-only.ll<br>
  test/MC/ARM/elf-execute-only-section.ll<br>
  test/MC/ELF/ARM/execute-only-populated-text-section.s<br>
  test/MC/ELF/ARM/execute-only-section.s<br>
  test/MC/ELF/ARM/execute-only-text-section-data.s<br>
<br>
</blockquote></div>