<div dir="ltr"><div>Right.</div><div>I was mainly concerned about the assert. Thanks for fixing it! :-)<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 21, 2018 at 8:25 AM, Kirill Bobyrev via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">kbobyrev marked an inline comment as done.<br>
kbobyrev added a comment.<br>
<br>
Fixed the assertion in <a href="https://reviews.llvm.org/rL340252" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>rL340252</a>. My comments about `compare_lower()` are inline.<br>
<span class=""><br>
<br>
<br>
================<br>
Comment at: llvm/trunk/include/llvm/<wbr>Support/YAMLTraits.h:464<br>
<br>
-  static const char HexChars[] = "0123456789abcdefABCDEF";<br>
-  if (S.startswith("0x") &&<br>
-      S.drop_front(2).find_first_<wbr>not_of(HexChars) == StringRef::npos)<br>
+  if (S.equals(".nan") || S.equals(".NaN") || S.equals(".NAN"))<br>
     return true;<br>
----------------<br>
</span><span class="">andreadb wrote:<br>
> You can probably use `StringRef::compare_lower()` rather than enumerating all the possible strings in input.<br>
</span>`.nAN`, `.Nan` will be allowed then, same with infinity.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D50839" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D50839</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div>