<div dir="ltr">Reverted both with r340202</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 20, 2018 at 12:26 PM Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You will need to revert r340172 too because it fixes compilation issues <br>
reported by buildbot. If you think it will be easier, feel free to <br>
revert both.<br>
<br>
On 8/20/18 9:22 PM, Vitaly Buka wrote:<br>
> Wound it be easier just revert and reland correct patch?<br>
> Also easier to backport it to other LLVM version as a single patch.<br>
> <br>
> On Mon, Aug 20, 2018 at 12:08 PM Samuel Pitoiset <br>
> <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a> <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>>> wrote:<br>
> <br>
> This should be fixed by <a href="https://reviews.llvm.org/D50974" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50974</a><br>
> <br>
> Sorry for the breakage and please don't revert it, I guess a fix should<br>
> be upstream soon.<br>
> <br>
> Thanks!<br>
> <br>
> On 8/20/18 8:36 PM, Vitaly Buka wrote:<br>
> > Not sure how this suppose to work.<br>
> > Now MAX_COMMON_ADDRESS allows to have AS1 and AS2 == 6<br>
> > and (*ASAliasRules)[AS1][AS2].<br>
> > but ASAliasRulesPrivIsZero and ASAliasRulesGenIsZero had only 6<br>
> elements<br>
> ><br>
> > If no one is looking, I am going to revert.<br>
> ><br>
> > On Mon, Aug 20, 2018 at 11:24 AM Vitaly Buka<br>
> <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a> <mailto:<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>><br>
> > <mailto:<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a> <mailto:<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>>>> wrote:<br>
> ><br>
> > Similar for msan<br>
> ><br>
> <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/6784" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/6784</a><br>
> > and ubsan<br>
> ><br>
> <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/5631/steps/check-llvm%20ubsan/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/5631/steps/check-llvm%20ubsan/logs/stdio</a><br>
> ><br>
> > On Mon, Aug 20, 2018 at 11:22 AM Vitaly Buka<br>
> <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a> <mailto:<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>><br>
> > <mailto:<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a><br>
> <mailto:<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>>>> wrote:<br>
> ><br>
> > This looks caused by the patch<br>
> ><br>
> <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/6883/steps/check-llvm%20asan/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/6883/steps/check-llvm%20asan/logs/stdio</a><br>
> ><br>
> > FAIL: LLVM :: CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> (5325 of<br>
> > 27229) ******************** TEST 'LLVM ::<br>
> > CodeGen/AMDGPU/amdgpu-alias-analysis.ll' FAILED<br>
> > ******************** Script: -- : 'RUN: at line 1';<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/opt<br>
> -mtriple=amdgcn--<br>
> > -O3 -aa-eval -print-all-alias-modref-info -disable-output <<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > 2>&1 |<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/FileCheck<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > : 'RUN: at line 2';<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/opt<br>
> -mtriple=r600--<br>
> > -O3 -aa-eval -print-all-alias-modref-info -disable-output <<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > 2>&1 |<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/FileCheck<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > -- Exit Code: 1 Command Output (stderr): --<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll:10:10:<br>
> > error: CHECK: expected string not found in input ; CHECK:<br>
> > NoAlias: i8 addrspace(1)* %p1, i8 addrspace(6)* %p ^<br>
> > <stdin>:3:1: note: scanning from here Function:<br>
> > test_32bit_addr_space: 2 pointers, 0 call sites ^<br>
> <stdin>:3:5:<br>
> > note: possible intended match here Function:<br>
> > test_32bit_addr_space: 2 pointers, 0 call sites ^ --<br>
> > ******************** Testing: 0 .. 10.. 20 FAIL: LLVM ::<br>
> > CodeGen/AMDGPU/widen-smrd-loads.ll (6391 of 27229)<br>
> > ******************** TEST 'LLVM ::<br>
> > CodeGen/AMDGPU/widen-smrd-loads.ll' FAILED<br>
> ********************<br>
> > Script: -- : 'RUN: at line 1';<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/llc<br>
> -amdgpu-codegenprepare-widen-constant-loads=0<br>
> > -march=amdgcn -mcpu=tahiti -verify-machineinstrs <<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/widen-smrd-loads.ll<br>
> > |<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/FileCheck<br>
> > -enable-var-scope -check-prefixes=GCN,SI<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/widen-smrd-loads.ll<br>
> > : 'RUN: at line 2';<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/llc<br>
> -amdgpu-codegenprepare-widen-constant-loads=0<br>
> > -march=amdgcn -mcpu=tonga -verify-machineinstrs <<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/widen-smrd-loads.ll<br>
> > |<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/FileCheck<br>
> > -enable-var-scope -check-prefixes=GCN,VI<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/widen-smrd-loads.ll<br>
> > -- Exit Code: 1 Command Output (stderr): --<br>
> > <br>
> =================================================================<br>
> ==22327==ERROR:<br>
> > AddressSanitizer: global-buffer-overflow on address<br>
> > 0x000007134b68 at pc 0x0000012c05c8 bp 0x7fff2e2b6b40 sp<br>
> > 0x7fff2e2b6b38 READ of size 1 at 0x000007134b68 thread T0 #0<br>
> > 0x12c05c7 in getAliasResult<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:99:10<br>
> > #1 0x12c05c7 in<br>
> llvm::AMDGPUAAResult::alias(llvm::MemoryLocation<br>
> > const&, llvm::MemoryLocation const&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:107<br>
> > #2 0x3367dc1 in llvm::AAResults::alias(llvm::MemoryLocation<br>
> > const&, llvm::MemoryLocation const&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/AliasAnalysis.cpp:105:23<br>
> > #3 0x3396a90 in alias<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/Analysis/AliasAnalysis.h:896:25<br>
> > #4 0x3396a90 in llvm::BasicAAResult::aliasCheck(llvm::Value<br>
> > const*, unsigned long, llvm::AAMDNodes, llvm::Value const*,<br>
> > unsigned long, llvm::AAMDNodes, llvm::Value const*,<br>
> llvm::Value<br>
> > const*)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/BasicAliasAnalysis.cpp:1779<br>
> > #5 0x33951de in<br>
> llvm::BasicAAResult::alias(llvm::MemoryLocation<br>
> > const&, llvm::MemoryLocation const&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/BasicAliasAnalysis.cpp:780:23<br>
> > #6 0x3367dc1 in llvm::AAResults::alias(llvm::MemoryLocation<br>
> > const&, llvm::MemoryLocation const&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/AliasAnalysis.cpp:105:23<br>
> > #7 0x35d070c in<br>
> > <br>
> llvm::MemoryDependenceResults::getSimplePointerDependencyFrom(llvm::MemoryLocation<br>
> > const&, bool,<br>
> > <br>
> llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction,<br>
> > true, false, void>, false, false>, llvm::BasicBlock*,<br>
> > llvm::Instruction*, unsigned int*)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:577:26<br>
> > #8 0x35cfb45 in<br>
> > <br>
> llvm::MemoryDependenceResults::getSimplePointerDependencyFrom(llvm::MemoryLocation<br>
> > const&, bool,<br>
> > <br>
> llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction,<br>
> > true, false, void>, false, false>, llvm::BasicBlock*,<br>
> > llvm::Instruction*, unsigned int*)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:448:12<br>
> > #9 0x35ce759 in<br>
> > <br>
> llvm::MemoryDependenceResults::getPointerDependencyFrom(llvm::MemoryLocation<br>
> > const&, bool,<br>
> > <br>
> llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction,<br>
> > true, false, void>, false, false>, llvm::BasicBlock*,<br>
> > llvm::Instruction*, unsigned int*)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:341:28<br>
> > #10 0x12c95d4 in isClobberedInFunction<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:112:19<br>
> > #11 0x12c95d4 in visitLoadInst<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:142<br>
> > #12 0x12c95d4 in visitLoad<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/Instruction.def:153<br>
> > #13 0x12c95d4 in visit<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/Instruction.def:153<br>
> > #14 0x12c95d4 in<br>
> > <br>
> visit<llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction,<br>
> > true, false, void>, false, false> ><br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/InstVisitor.h:92<br>
> > #15 0x12c95d4 in visit<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/InstVisitor.h:107<br>
> > #16 0x12c95d4 in<br>
> > <br>
> visit<llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::BasicBlock,<br>
> > true, false, void>, false, false> ><br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/InstVisitor.h:92<br>
> > #17 0x12c95d4 in visit<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/include/llvm/IR/InstVisitor.h:103<br>
> > #18 0x12c95d4 in (anonymous<br>
> > <br>
> namespace)::AMDGPUAnnotateUniformValues::runOnFunction(llvm::Function&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:184<br>
> > #19 0x47fea6d in<br>
> > llvm::FPPassManager::runOnFunction(llvm::Function&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/IR/LegacyPassManager.cpp:1586:27<br>
> > #20 0x3464f8c in RunPassOnSCC<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/CallGraphSCCPass.cpp:166:25<br>
> > #21 0x3464f8c in RunAllPassesOnSCC<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/CallGraphSCCPass.cpp:430<br>
> > #22 0x3464f8c in (anonymous<br>
> > namespace)::CGPassManager::runOnModule(llvm::Module&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Analysis/CallGraphSCCPass.cpp:486<br>
> > #23 0x47ffe7e in runOnModule<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/IR/LegacyPassManager.cpp:1669:27<br>
> > #24 0x47ffe7e in<br>
> > llvm::legacy::PassManagerImpl::run(llvm::Module&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/IR/LegacyPassManager.cpp:1774<br>
> > #25 0xa074af in compileModule(char**, llvm::LLVMContext&)<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/llc/llc.cpp:597:8<br>
> > #26 0xa00ae0 in main<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/llc/llc.cpp:351:22<br>
> > #27 0x7f33f66c22e0 in __libc_start_main<br>
> > (/lib/x86_64-linux-gnu/libc.so.6+0x202e0) #28 0x8f4b99 in<br>
> _start<br>
> > <br>
> (/b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/llc+0x8f4b99)<br>
> > 0x000007134b68 is located 56 bytes to the left of global<br>
> > variable '<string literal>' defined in<br>
> > <br>
> '/b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:74:5'<br>
> > (0x7134ba0) of size 129 '<string literal>' is ascii string<br>
> > 'AS.GLOBAL_ADDRESS == 1 && AS.REGION_ADDRESS == 2 &&<br>
> > AS.LOCAL_ADDRESS == 3 && AS.CONSTANT_ADDRESS == 4 &&<br>
> > AS.PRIVATE_ADDRESS == 5' 0x000007134b68 is located 4 bytes to<br>
> > the right of global variable 'ASAliasRulesGenIsZero'<br>
> defined in<br>
> > <br>
> '/b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:63:28'<br>
> > (0x7134b40) of size 36 SUMMARY: AddressSanitizer:<br>
> > global-buffer-overflow<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:99:10<br>
> > in getAliasResult Shadow bytes around the buggy address:<br>
> > 0x000080e1e910: 00 00 00 00 00 00 00 00 00 07 f9 f9 f9 f9<br>
> f9 f9<br>
> > 0x000080e1e920: 00 00 00 00 00 00 00 01 f9 f9 f9 f9 00 00<br>
> 00 00<br>
> > 0x000080e1e930: 00 00 00 00 00 00 00 00 00 00 00 00 00 00<br>
> 00 00<br>
> > 0x000080e1e940: f9 f9 f9 f9 00 00 00 00 00 03 f9 f9 f9 f9<br>
> f9 f9<br>
> > 0x000080e1e950: 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 00 00<br>
> 00 00<br>
> > =>0x000080e1e960: 00 00 00 00 00 00 00 00 00 00 00 00<br>
> 04[f9]f9<br>
> > f9 0x000080e1e970: f9 f9 f9 f9 00 00 00 00 00 00 00 00 00<br>
> 00 00<br>
> > 00 0x000080e1e980: 00 00 00 00 01 f9 f9 f9 f9 f9 f9 f9 00<br>
> 00 00<br>
> > 00 0x000080e1e990: 00 00 00 00 00 00 00 01 f9 f9 f9 f9 00<br>
> 00 00<br>
> > 00 0x000080e1e9a0: 00 00 00 00 00 00 01 f9 f9 f9 f9 f9 00<br>
> 00 00<br>
> > 00 0x000080e1e9b0: 00 00 00 00 00 00 00 00 00 00 00 00 00<br>
> 00 00<br>
> > 01 Shadow byte legend (one shadow byte represents 8<br>
> application<br>
> > bytes): Addressable: 00 Partially addressable: 01 02 03<br>
> 04 05 06<br>
> > 07 Heap left redzone: fa Freed heap region: fd Stack left<br>
> > redzone: f1 Stack mid redzone: f2 Stack right redzone: f3<br>
> Stack<br>
> > after return: f5 Stack use after scope: f8 Global redzone: f9<br>
> > Global init order: f6 Poisoned by user: f7 Container<br>
> overflow:<br>
> > fc Array cookie: ac Intra object redzone: bb ASan<br>
> internal: fe<br>
> > Left alloca redzone: ca Right alloca redzone: cb Shadow<br>
> gap: cc<br>
> > ==22327==ABORTING<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm/test/CodeGen/AMDGPU/widen-smrd-loads.ll:143:14:<br>
> > error: GCN-LABEL: expected string not found in input ;<br>
> > GCN-LABEL: {{^}}widen_i16_constant32_load: ^ <stdin>:518:37:<br>
> > note: scanning from here<br>
> widen_i1_zext_to_i64_constant_load: ;<br>
> > @widen_i1_zext_to_i64_constant_load ^ <stdin>:518:48: note:<br>
> > possible intended match here<br>
> widen_i1_zext_to_i64_constant_load:<br>
> > ; @widen_i1_zext_to_i64_constant_load ^ --<br>
> ********************<br>
> > Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..<br>
> > Testing Time: 384.24s ******************** Failing Tests (2):<br>
> > LLVM :: CodeGen/AMDGPU/amdgpu-alias-analysis.ll LLVM ::<br>
> > CodeGen/AMDGPU/widen-smrd-loads.ll Expected Passes : 26393<br>
> > Expected Failures : 148 Unsupported Tests : 686 Unexpected<br>
> > Failures: 2 FAILED: test/CMakeFiles/check-llvm cd<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/test<br>
> > && /usr/bin/python2.7<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/./bin/llvm-lit<br>
> > -sv<br>
> > <br>
> /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/test<br>
> > ninja: build stopped: subcommand failed. + echo<br>
> > @@@STEP_FAILURE@@@ + echo @@@BUILD_STEP check-clang asan@@@<br>
> > @@@STEP_FAILURE@@@<br>
> > <br>
> --------------------------------------------------------------------------------<br>
> > started: Mon Aug 20 06:50:07 2018 ended: Mon Aug 20 07:15:07<br>
> > 2018 duration: 24 mins, 59 secs<br>
> ><br>
> ><br>
> > On Mon, Aug 20, 2018 at 6:19 AM Samuel Pitoiset via<br>
> llvm-commits<br>
> > <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
> > <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>>> wrote:<br>
> ><br>
> > Author: hakzsam<br>
> > Date: Mon Aug 20 06:18:59 2018<br>
> > New Revision: 340171<br>
> ><br>
> > URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project?rev=340171&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=340171&view=rev</a><br>
> > Log:<br>
> > AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit<br>
> addr space<br>
> ><br>
> > 32-bit constant address space is declared as 6, so the<br>
> > maximum number of address spaces is 6, not 5.<br>
> ><br>
> > Fixes "LLVM ERROR: Pointer address space out of range".<br>
> ><br>
> > v3: use static_assert()<br>
> > v2: add a very simple test for 32-bit addr space<br>
> ><br>
> > Bugzilla:<br>
> <a href="https://bugs.freedesktop.org/show_bug.cgi?id=106630" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=106630</a><br>
> > Signed-off-by: Samuel Pitoiset<br>
> <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a> <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>><br>
> > <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a><br>
> <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>>>><br>
> ><br>
> > Modified:<br>
> > llvm/trunk/lib/Target/AMDGPU/AMDGPU.h<br>
> > llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp<br>
> > <br>
> llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> ><br>
> > Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPU.h<br>
> > URL:<br>
> ><br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPU.h?rev=340171&r1=340170&r2=340171&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPU.h?rev=340171&r1=340170&r2=340171&view=diff</a><br>
> > <br>
> ==============================================================================<br>
> > --- llvm/trunk/lib/Target/AMDGPU/AMDGPU.h (original)<br>
> > +++ llvm/trunk/lib/Target/AMDGPU/AMDGPU.h Mon Aug 20<br>
> > 06:18:59 2018<br>
> > @@ -229,7 +229,7 @@ struct AMDGPUAS {<br>
> ><br>
> > enum : unsigned {<br>
> > // The maximum value for flat, generic, local,<br>
> > private, constant and region.<br>
> > - MAX_COMMON_ADDRESS = 5,<br>
> > + MAX_COMMON_ADDRESS = 6,<br>
> ><br>
> > GLOBAL_ADDRESS = 1, ///< Address space for global<br>
> > memory (RAT0, VTX0).<br>
> > CONSTANT_ADDRESS = 4, ///< Address space for<br>
> constant<br>
> > memory (VTX2)<br>
> ><br>
> > Modified:<br>
> llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp<br>
> > URL:<br>
> ><br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp?rev=340171&r1=340170&r2=340171&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp?rev=340171&r1=340170&r2=340171&view=diff</a><br>
> > <br>
> ==============================================================================<br>
> > --- llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp<br>
> > (original)<br>
> > +++<br>
> llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp Mon<br>
> > Aug 20 06:18:59 2018<br>
> > @@ -69,7 +69,7 @@<br>
> AMDGPUAAResult::ASAliasRulesTy::ASAliasR<br>
> > /* Region */ {MayAlias, NoAlias , NoAlias ,<br>
> NoAlias,<br>
> > MayAlias, NoAlias},<br>
> > /* Private */ {MayAlias, NoAlias , NoAlias ,<br>
> NoAlias ,<br>
> > NoAlias , MayAlias}<br>
> > };<br>
> > - assert(AS.MAX_COMMON_ADDRESS <= 5);<br>
> > + static_assert(AS.MAX_COMMON_ADDRESS <= 6, "Addr<br>
> space out<br>
> > of range");<br>
> > if (AS.FLAT_ADDRESS == 0) {<br>
> > assert(AS.GLOBAL_ADDRESS == 1 &&<br>
> > AS.REGION_ADDRESS == 2 &&<br>
> ><br>
> > Modified:<br>
> > llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > URL:<br>
> ><br>
> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll?rev=340171&r1=340170&r2=340171&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll?rev=340171&r1=340170&r2=340171&view=diff</a><br>
> > <br>
> ==============================================================================<br>
> > ---<br>
> llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > (original)<br>
> > +++<br>
> llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll<br>
> > Mon Aug 20 06:18:59 2018<br>
> > @@ -7,3 +7,9 @@ define void @test(i8 addrspace(5)* %p, i<br>
> > ret void<br>
> > }<br>
> ><br>
> > +; CHECK: NoAlias: i8 addrspace(1)* %p1, i8<br>
> > addrspace(6)* %p<br>
> > +<br>
> > +define void @test_32bit_addr_space(i8 addrspace(6)*<br>
> %p, i8<br>
> > addrspace(1)* %p1) {<br>
> > + ret void<br>
> > +}<br>
> > +<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>><br>
> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> ><br>
> <br>
</blockquote></div>