<div dir="ltr">Thanks guys, I'll look into it.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 10, 2018 at 12:23 PM Sanjay Patel <<a href="mailto:spatel@rotateright.com">spatel@rotateright.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I reverted this change at r339463 to try to get the bots back to green. It was also failing 'make check' for me locally on macOS. Let me know if I can provide any other info.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 10, 2018 at 1:20 PM, Matt Morehouse via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Zach,<div><br></div><div>This test is failing:  <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22180" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22180</a></div><div><br></div><div><pre style="font-family:"Courier New",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium;text-decoration-style:initial;text-decoration-color:initial"><span class="m_-4585525174197073023m_2553826304902880130gmail-stdout" style="font-family:"Courier New",courier,monotype,monospace;color:black">llvm-undname: /b/sanitizer-x86_64-linux-fast/build/llvm/lib/Demangle/MicrosoftDemangle.cpp:740: virtual void (anonymous namespace)::Type::outputPre(OutputStream &, (anonymous namespace)::NameResolver &): Assertion `false && "Invalid primitive type!"' failed.</span></pre>Please take a look.</div></div><div class="m_-4585525174197073023HOEnZb"><div class="m_-4585525174197073023h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 10, 2018 at 9:56 AM Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Fri Aug 10 09:55:59 2018<br>
New Revision: 339450<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=339450&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=339450&view=rev</a><br>
Log:<br>
[MS Demangler] Add conversion operator tests.<br>
<br>
The mangled names were added in the original commit, but<br>
the demangled equivalents weren't, so nothing was actually<br>
being checked.<br>
<br>
Modified:<br>
    llvm/trunk/test/Demangle/ms-conversion-operators.test<br>
<br>
Modified: llvm/trunk/test/Demangle/ms-conversion-operators.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Demangle/ms-conversion-operators.test?rev=339450&r1=339449&r2=339450&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Demangle/ms-conversion-operators.test?rev=339450&r1=339449&r2=339450&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Demangle/ms-conversion-operators.test (original)<br>
+++ llvm/trunk/test/Demangle/ms-conversion-operators.test Fri Aug 10 09:55:59 2018<br>
@@ -3,19 +3,49 @@<br>
 ; CHECK-NOT: Invalid mangled name<br>
<br>
 ??$?BH@TemplateOps@@QAEHXZ<br>
+; CHECK: int __thiscall TemplateOps::operator<int> int(void)<br>
+<br>
 ??BOps@@QAEHXZ<br>
+; CHECK: int __thiscall Ops::operator int(void)<br>
+<br>
 ??BConstOps@@QAE?BHXZ<br>
+; CHECK: int const __thiscall ConstOps::operator int const(void)<br>
+<br>
 ??BVolatileOps@@QAE?CHXZ<br>
+; CHECK: int volatile __thiscall VolatileOps::operator int volatile(void)<br>
+<br>
 ??BConstVolatileOps@@QAE?DHXZ<br>
+; CHECK: int const volatile __thiscall ConstVolatileOps::operator int const volatile(void)<br>
+<br>
 ??$?BN@TemplateOps@@QAENXZ<br>
+; CHECK: double __thiscall TemplateOps::operator<double> double(void)<br>
+<br>
 ??BOps@@QAENXZ<br>
+; CHECK: double __thiscall Ops::operator double(void)<br>
+<br>
 ??BConstOps@@QAE?BNXZ<br>
+; CHECK: double const __thiscall ConstOps::operator double const(void)<br>
+<br>
 ??BVolatileOps@@QAE?CNXZ<br>
+; CHECK: double volatile __thiscall VolatileOps::operator double volatile(void)<br>
+<br>
 ??BConstVolatileOps@@QAE?DNXZ<br>
+; CHECK: double const volatile __thiscall ConstVolatileOps::operator double const volatile(void)<br>
+<br>
 ??BCompoundTypeOps@@QAEPAHXZ<br>
+i; CHECK: nt * __thiscall CompoundTypeOps::operator int *(void)<br>
+<br>
 ??BCompoundTypeOps@@QAEPBHXZ<br>
+; CHECK: int const * __thiscall CompoundTypeOps::operator int const *(void)<br>
+<br>
 ??BCompoundTypeOps@@QAE$$QAHXZ<br>
+; CHECK: int && __thiscall CompoundTypeOps::operator int &&(void)<br>
+<br>
 ??BCompoundTypeOps@@QAE?AU?$Foo@H@@XZ<br>
+; CHECK: struct Foo<int> __thiscall CompoundTypeOps::operator struct Foo<int>(void)<br>
+<br>
 ??$?BH@CompoundTypeOps@@QAE?AU?$Bar@U?$Foo@H@@@@XZ<br>
-??$?BPAH@TemplateOps@@QAEPAHXZ<br>
+; CHECK: struct Bar<struct Foo<int>> __thiscall CompoundTypeOps::operator<int> struct Bar<struct Foo<int>>(void)<br>
<br>
+??$?BPAH@TemplateOps@@QAEPAHXZ<br>
+; CHECK: int * __thiscall TemplateOps::operator<int *> int *(void)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div>