Lgtm<br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 7, 2018 at 1:42 PM Nico Weber via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">thakis created this revision.<br>
thakis added reviewers: zturner, hans.<br>
<br>
We do need to map /Zi to /Z7 explicitly for msbuild as explained in this file, but since /Zi is passed by default and since things transparently work fine with it mapped to /Z7, we shouldn't produce effectively inactionable noise for it.<br>
<br>
Also don't warn on /X since clang-cl supports that (since r326357; the risk of duplicating a bunch of clang-cl driver logic here).<br>
<br>
<br>
<a href="https://reviews.llvm.org/D50398" rel="noreferrer" target="_blank">https://reviews.llvm.org/D50398</a><br>
<br>
Files:<br>
llvm/tools/msbuild/LLVM.Cpp.Common.targets<br>
<br>
<br>
Index: llvm/tools/msbuild/LLVM.Cpp.Common.targets<br>
===================================================================<br>
--- llvm/tools/msbuild/LLVM.Cpp.Common.targets<br>
+++ llvm/tools/msbuild/LLVM.Cpp.Common.targets<br>
@@ -40,10 +40,7 @@<br>
to look at the tool output.<br>
--><br>
<Target Name="BeforeClCompile" BeforeTargets="ClCompile"><br>
- <!-- Warn on /Zi and /ZI, then map them both to /Z7. --><br>
- <Warning Condition="'%(ClCompile.DebugInformationFormat)' == 'ProgramDatabase'"<br>
- File="@(ClCompile)(0,0)"<br>
- Text="clang-cl does not support /Zi (Program Database). The file will be compiled as if /Z7 (C7 Compatible Debug Info) had been passed. Update the Debug Information Format in project settings to silence this warning."/><br>
+ <!-- Warn on /ZI, then map to /Z7. /Zi is mapped to /Z7 below too (see comment there), but don't warn on that. --><br>
<Warning Condition="'%(ClCompile.DebugInformationFormat)' == 'EditAndContinue'"<br>
File="@(ClCompile)(0,0)"<br>
Text="clang-cl does not support /ZI (Program Database for Edit and Continue). The file will be compiled as if /Z7 (C7 Compatible Debug Info) had been passed. Update the Debug Information Format in project settings to silence this warning."/><br>
@@ -58,11 +55,6 @@<br>
File="@(ClCompile)(0,0)"<br>
Text="clang-cl does not support MSVC Link Time Optimization. Disable this option in compatibility settings to silence this warning."/><br>
<br>
- <!-- Warn if Ignore Standard Include Paths is non-empty, then ignore it. --><br>
- <Warning Condition="'%(ClCompile.IgnoreStandardIncludePath)' == 'true'"<br>
- File="@(ClCompile)(0,0)"<br>
- Text="clang-cl does not support Ignore Standard Include Path (/X). Disable this option in compatibility settings to silence this warning."/><br>
-<br>
<!-- Warn if Smaller Type Check is enabled, then ignore it.--><br>
<Warning Condition="'%(ClCompile.SmallerTypeCheck)' == 'true'"<br>
File="@(ClCompile)(0,0)"<br>
<br>
<br>
</blockquote></div>