<div dir="ltr">Test case?</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Aug 5, 2018 at 4:55 PM Lang Hames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Sun Aug  5 16:55:35 2018<br>
New Revision: 338975<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=338975&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=338975&view=rev</a><br>
Log:<br>
[ORC] Remove an incorrect use of 'cantFail'.<br>
<br>
This code was moved out from BasicObjectLayerMaterializationUnit, which required<br>
the supplied object to be well formed. The getObjectSymbolFlags function does<br>
not require a well-formed object, so we have to propagate the error here.<br>
<br>
Modified:<br>
    llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp?rev=338975&r1=338974&r2=338975&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp?rev=338975&r1=338974&r2=338975&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp Sun Aug  5 16:55:35 2018<br>
@@ -116,8 +116,10 @@ Expected<SymbolFlagsMap> getObjectSymbol<br>
   for (auto &Sym : (*Obj)->symbols()) {<br>
     if (!(Sym.getFlags() & object::BasicSymbolRef::SF_Undefined) &&<br>
         (Sym.getFlags() & object::BasicSymbolRef::SF_Exported)) {<br>
-      auto InternedName =<br>
-          ES.getSymbolStringPool().intern(cantFail(Sym.getName()));<br>
+      auto Name = Sym.getName();<br>
+      if (!Name)<br>
+        return Name.takeError();<br>
+      auto InternedName = ES.getSymbolStringPool().intern(*Name);<br>
       auto SymFlags = JITSymbolFlags::fromObjectSymbol(Sym);<br>
       if (!SymFlags)<br>
         return SymFlags.takeError();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>