<div dir="ltr">Is this NFC? It looks like you've changed the startswith to an exact comparison.<div><br></div><div>Peter</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 1, 2018 at 10:33 AM Rui Ueyama via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Wed Aug  1 10:33:00 2018<br>
New Revision: 338596<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=338596&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=338596&view=rev</a><br>
Log:<br>
Simplify. NFC.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Driver.cpp<br>
<br>
Modified: lld/trunk/ELF/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=338596&r1=338595&r2=338596&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=338596&r1=338595&r2=338596&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Driver.cpp (original)<br>
+++ lld/trunk/ELF/Driver.cpp Wed Aug  1 10:33:00 2018<br>
@@ -497,14 +497,11 @@ static Target2Policy getTarget2(opt::Inp<br>
 }<br>
<br>
 static bool isOutputFormatBinary(opt::InputArgList &Args) {<br>
-  if (auto *Arg = Args.getLastArg(OPT_oformat)) {<br>
-    StringRef S = Arg->getValue();<br>
-    if (S == "binary")<br>
-      return true;<br>
-    if (S.startswith("elf"))<br>
-      return false;<br>
+  StringRef S = Args.getLastArgValue(OPT_oformat, "elf");<br>
+  if (S == "binary")<br>
+    return true;<br>
+  if (S != "elf")<br>
     error("unknown --oformat value: " + S);<br>
-  }<br>
   return false;<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>