<div dir="ltr">Hello Daniel,<br><br>This commit broke tests on one of our builders:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10982">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10982</a><br><br>. . . <br>Failing Tests (1):<br>    LLVM :: CodeGen/SPARC/trap.ll<br><br>Please have a look?<br><br>Thanks<br><br>Galina<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 16, 2018 at 5:16 AM, Daniel Cederman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dcederman<br>
Date: Mon Jul 16 05:16:53 2018<br>
New Revision: 337163<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=337163&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=337163&view=rev</a><br>
Log:<br>
[Sparc] Generate ta 1 for the @llvm.debugtrap intrinsic<br>
<br>
Summary: Software trap number one is the trap used for breakpoints<br>
in the Sparc ABI.<br>
<br>
Reviewers: jyknight, venkatra<br>
<br>
Reviewed By: jyknight<br>
<br>
Subscribers: fedor.sergeev, jrtc27, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D48637" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D48637</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Sparc/<wbr>SparcISelLowering.cpp<br>
    llvm/trunk/lib/Target/Sparc/<wbr>SparcInstrInfo.td<br>
    llvm/trunk/test/CodeGen/SPARC/<wbr>trap.ll<br>
<br>
Modified: llvm/trunk/lib/Target/Sparc/<wbr>SparcISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcISelLowering.cpp?rev=337163&r1=337162&r2=337163&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>Sparc/SparcISelLowering.cpp?<wbr>rev=337163&r1=337162&r2=<wbr>337163&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/Sparc/<wbr>SparcISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/Sparc/<wbr>SparcISelLowering.cpp Mon Jul 16 05:16:53 2018<br>
@@ -1727,6 +1727,7 @@ SparcTargetLowering::<wbr>SparcTargetLowering<br>
   setOperationAction(ISD::VAARG             , MVT::Other, Custom);<br>
<br>
   setOperationAction(ISD::TRAP              , MVT::Other, Legal);<br>
+  setOperationAction(ISD::<wbr>DEBUGTRAP         , MVT::Other, Legal);<br>
<br>
   // Use the default implementation.<br>
   setOperationAction(ISD::VACOPY            , MVT::Other, Expand);<br>
<br>
Modified: llvm/trunk/lib/Target/Sparc/<wbr>SparcInstrInfo.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcInstrInfo.td?rev=337163&r1=337162&r2=337163&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>Sparc/SparcInstrInfo.td?rev=<wbr>337163&r1=337162&r2=337163&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/Sparc/<wbr>SparcInstrInfo.td (original)<br>
+++ llvm/trunk/lib/Target/Sparc/<wbr>SparcInstrInfo.td Mon Jul 16 05:16:53 2018<br>
@@ -1009,6 +1009,9 @@ let DecoderNamespace = "SparcV9", Decode<br>
 let isBarrier = 1, isTerminator = 1, rd = 0b01000, rs1 = 0, simm13 = 5 in<br>
   def TA5 : F3_2<0b10, 0b111010, (outs), (ins), "ta 5", [(trap)]>;<br>
<br>
+def : Pat<(debugtrap),<br>
+  (TRAPri (i32 G0), (i32 1), (i32 8))>;<br>
+<br>
 // Section B.28 - Read State Register Instructions<br>
 let rs2 = 0 in<br>
   def RDASR : F3_1<2, 0b101000,<br>
<br>
Modified: llvm/trunk/test/CodeGen/SPARC/<wbr>trap.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/SPARC/trap.ll?rev=337163&r1=337162&r2=337163&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>CodeGen/SPARC/trap.ll?rev=<wbr>337163&r1=337162&r2=337163&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/CodeGen/SPARC/<wbr>trap.ll (original)<br>
+++ llvm/trunk/test/CodeGen/SPARC/<wbr>trap.ll Mon Jul 16 05:16:53 2018<br>
@@ -9,3 +9,13 @@ define void @test1() {<br>
 }<br>
<br>
 declare void @llvm.trap()<br>
+<br>
+; CHECK-LABEL: testdebugtrap:<br>
+; CHECK: ta 1 ! encoding: [0x91,0xd0,0x20,0x01]<br>
+define void @testdebugtrap() {<br>
+entry:<br>
+  call void @llvm.debugtrap()<br>
+  ret void<br>
+}<br>
+<br>
+declare void @llvm.debugtrap()<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>