<div dir="ltr"><div>I'm not sure what KernelCode should initialized to, so reverted in r337079.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 13, 2018 at 6:18 PM, Evgenii Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, Jul 13, 2018 at 5:39 PM, Evgenii Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class=""><div dir="ltr">Hi,<div><br></div><div>MSan is not happy about this change, but the report in unfortunately truncated:</div><div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/5926/steps/check-llvm%20msan/logs/stdio" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/sanitizer-x86_64-linux-<wbr>bootstrap-msan/builds/5926/<wbr>steps/check-llvm%20msan/logs/<wbr>stdio</a><br></div></div></span><div class="m_4233881168510887867gmail-HOEnZb"><div class="m_4233881168510887867gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote"><br><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Modified: llvm/trunk/lib/Target/AMDGPU/A<wbr>MDGPUAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp?rev=337021&r1=337020&r2=337021&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Target/AM<wbr>DGPU/AMDGPUAsmPrinter.cpp?rev=<wbr>337021&r1=337020&r2=337021&vie<wbr>w=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/AMDGPU/A<wbr>MDGPUAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/AMDGPU/A<wbr>MDGPUAsmPrinter.cpp Fri Jul 13 09:40:25 2018<br>
@@ -1128,6 +1128,13 @@ static amd_element_byte_size_t getElemen<br>
void AMDGPUAsmPrinter::getAmdKernel<wbr>Code(amd_kernel_code_t &Out,<br>
const SIProgramInfo &CurrentProgramInfo,<br>
const MachineFunction &MF) const {<br>
+ const Function &F = MF.getFunction();<br>
+<br>
+ // Avoid asserting on erroneous cases.<br>
+ if (F.getCallingConv() != CallingConv::AMDGPU_KERNEL &&<br>
+ F.getCallingConv() != CallingConv::SPIR_KERNEL)<br>
+ return;<br>
+<br></blockquote></span></div></div></div></div></blockquote><div><br></div><div>This function can return w/o initializing the &Out argument.</div><div> </div><div><div>WARNING: MemorySanitizer: use-of-uninitialized-value</div><div> #0 0x1415cd65 in void write_signed<long>(llvm::raw_<wbr>ostream&, long, unsigned long, llvm::IntegerStyle) /code/llvm-project/llvm/lib/<wbr>Support/NativeFormatting.cpp:<wbr>95:7</div><div> #1 0x1415c900 in llvm::write_integer(llvm::raw_<wbr>ostream&, long, unsigned long, llvm::IntegerStyle) /code/llvm-project/llvm/lib/<wbr>Support/NativeFormatting.cpp:<wbr>121:3</div><div> #2 0x1472357f in llvm::raw_ostream::operator<<(<wbr>long) /code/llvm-project/llvm/lib/<wbr>Support/raw_ostream.cpp:117:3</div><div> #3 0x13bb9d4 in llvm::raw_ostream::operator<<(<wbr>int) /code/llvm-project/llvm/<wbr>include/llvm/Support/raw_<wbr>ostream.h:210:18</div><div> #4 0x3c2bc18 in void printField<unsigned int, &(amd_kernel_code_s::amd_<wbr>kernel_code_version_major)>(<wbr>llvm::StringRef, amd_kernel_code_s const&, llvm::raw_ostream&) /code/llvm-project/llvm/lib/<wbr>Target/AMDGPU/Utils/<wbr>AMDKernelCodeTUtils.cpp:78:23</div><div> #5 0x3c250ba in llvm::printAmdKernelCodeField(<wbr>amd_kernel_code_s const&, int, llvm::raw_ostream&) /code/llvm-project/llvm/lib/<wbr>Target/AMDGPU/Utils/<wbr>AMDKernelCodeTUtils.cpp:104:5</div><div> #6 0x3c27ca3 in llvm::dumpAmdKernelCode(amd_<wbr>kernel_code_s const*, llvm::raw_ostream&, char const*) /code/llvm-project/llvm/lib/<wbr>Target/AMDGPU/Utils/<wbr>AMDKernelCodeTUtils.cpp:113:5</div><div> #7 0x3a46e6c in llvm::AMDGPUTargetAsmStreamer:<wbr>:EmitAMDKernelCodeT(amd_<wbr>kernel_code_s const&) /code/llvm-project/llvm/lib/<wbr>Target/AMDGPU/MCTargetDesc/<wbr>AMDGPUTargetStreamer.cpp:161:3</div><div> #8 0xd371e4 in llvm::AMDGPUAsmPrinter::<wbr>EmitFunctionBodyStart() /code/llvm-project/llvm/lib/<wbr>Target/AMDGPU/<wbr>AMDGPUAsmPrinter.cpp:204:26</div></div><div><br></div><div>[...]</div><div><br></div><div><div>Uninitialized value was created by an allocation of 'KernelCode' in the stack frame of function '_<wbr>ZN4llvm16AMDGPUAsmPrinter21Emi<wbr>tFunctionBodyStartEv'</div><div> #0 0xd36650 in llvm::AMDGPUAsmPrinter::<wbr>EmitFunctionBodyStart() /code/llvm-project/llvm/lib/<wbr>Target/AMDGPU/<wbr>AMDGPUAsmPrinter.cpp:192</div></div><div><br></div></div></div></div>
</blockquote></div><br></div>