<div dir="ltr">The bot is green as of r337044.<div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 13, 2018 at 1:48 PM Alex L <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Vlad,<div><br></div><div>Darwin doesn't support aliases, thus this commit has caused a regression in our CI. The build log is below:</div><div><br></div><div><a href="http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/47259/consoleFull#102734542449ba4694-19c4-4d7e-bec5-911270d8a58c" target="_blank">http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/47259/consoleFull#102734542449ba4694-19c4-4d7e-bec5-911270d8a58c</a><br></div><div><br></div><div>Do you mind working on a fix for this? Let me know if you need any help.</div><div><br></div><div>Cheers,</div><div>Alex</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 13 July 2018 at 12:48, Vlad Tsyrklevich via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vlad.tsyrklevich<br>
Date: Fri Jul 13 12:48:35 2018<br>
New Revision: 337037<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=337037&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=337037&view=rev</a><br>
Log:<br>
SafeStack: Add builtins to read unsafe stack top/bottom<br>
<br>
Summary:<br>
Introduce built-ins to read the unsafe stack top and bottom. The unsafe<br>
stack top is required to implement garbage collection scanning for<br>
Oilpan. Currently there is already a built-in 'get_unsafe_stack_start'<br>
to read the bottom of the unsafe stack, but I chose to duplicate this<br>
API because 'start' is ambiguous (e.g. Oilpan uses WTF::GetStackStart to<br>
read the safe stack top.)<br>
<br>
Reviewers: pcc<br>
<br>
Reviewed By: pcc<br>
<br>
Subscribers: llvm-commits, kcc<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D49152" rel="noreferrer" target="_blank">https://reviews.llvm.org/D49152</a><br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/safestack/safestack.cc<br>
<br>
Modified: compiler-rt/trunk/lib/safestack/safestack.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/safestack/safestack.cc?rev=337037&r1=337036&r2=337037&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/safestack/safestack.cc?rev=337037&r1=337036&r2=337037&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/safestack/safestack.cc (original)<br>
+++ compiler-rt/trunk/lib/safestack/safestack.cc Fri Jul 13 12:48:35 2018<br>
@@ -257,11 +257,20 @@ __attribute__((section(".preinit_array")<br>
 #endif<br>
<br>
 extern "C"<br>
-    __attribute__((visibility("default"))) void *__get_unsafe_stack_start() {<br>
+    __attribute__((visibility("default"))) void *__get_unsafe_stack_bottom() {<br>
   return unsafe_stack_start;<br>
 }<br>
<br>
 extern "C"<br>
+    __attribute__((visibility("default"))) void *__get_unsafe_stack_top() {<br>
+  return (char*)unsafe_stack_start + unsafe_stack_size;<br>
+}<br>
+<br>
+extern "C"<br>
+    __attribute__((visibility("default"), alias("__get_unsafe_stack_bottom")))<br>
+    void *__get_unsafe_stack_start();<br>
+<br>
+extern "C"<br>
     __attribute__((visibility("default"))) void *__get_unsafe_stack_ptr() {<br>
   return __safestack_unsafe_stack_ptr;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div></div></div>