<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">+Son Tuan Vu<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul. 13, 2018, at 11:08, Davide Italiano <<a href="mailto:davide@freebsd.org" class="">davide@freebsd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On Wed, Jul 11, 2018 at 4:35 PM Duncan P. N. Exon Smith via</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">llvm-commits <</span><a href="mailto:llvm-commits@lists.llvm.org" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">llvm-commits@lists.llvm.org</a><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">> wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="">Author: dexonsmith<br class="">Date: Wed Jul 11 16:30:25 2018<br class="">New Revision: 336869<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=336869&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=336869&view=rev</a><br class="">Log:<br class="">IR: Skip -print-*-all after -print-*<br class=""><br class="">This changes `-print-*` from transformation passes to analysis passes so<br class="">that `-print-after-all` and `-print-before-all` don't trigger. This<br class="">avoids some redundant output.<br class=""><br class="">Patch by Son Tuan Vu!<br class=""><br class="">Added:<br class=""> llvm/trunk/test/Other/printer.ll<br class="">Modified:<br class=""> llvm/trunk/lib/IR/IRPrintingPasses.cpp<br class=""><br class="">Modified: llvm/trunk/lib/IR/IRPrintingPasses.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/IRPrintingPasses.cpp?rev=336869&r1=336868&r2=336869&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/IRPrintingPasses.cpp?rev=336869&r1=336868&r2=336869&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/IR/IRPrintingPasses.cpp (original)<br class="">+++ llvm/trunk/lib/IR/IRPrintingPasses.cpp Wed Jul 11 16:30:25 2018<br class="">@@ -127,13 +127,13 @@ public:<br class=""><br class="">char PrintModulePassWrapper::ID = 0;<br class="">INITIALIZE_PASS(PrintModulePassWrapper, "print-module",<br class="">- "Print module to stderr", false, false)<br class="">+ "Print module to stderr", false, true)<br class="">char PrintFunctionPassWrapper::ID = 0;<br class="">INITIALIZE_PASS(PrintFunctionPassWrapper, "print-function",<br class="">- "Print function to stderr", false, false)<br class="">+ "Print function to stderr", false, true)<br class="">char PrintBasicBlockPass::ID = 0;<br class="">INITIALIZE_PASS(PrintBasicBlockPass, "print-bb", "Print BB to stderr", false,<br class="">- false)<br class="">+ true)<br class=""><br class="">ModulePass *llvm::createPrintModulePass(llvm::raw_ostream &OS,<br class=""> const std::string &Banner,<br class=""><br class="">Added: llvm/trunk/test/Other/printer.ll<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/printer.ll?rev=336869&view=auto" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/printer.ll?rev=336869&view=auto</a><br class="">==============================================================================<br class="">--- llvm/trunk/test/Other/printer.ll (added)<br class="">+++ llvm/trunk/test/Other/printer.ll Wed Jul 11 16:30:25 2018<br class="">@@ -0,0 +1,13 @@<br class="">+; RUN: opt -mem2reg -instcombine -print-after-all -S < %s 2>&1 | FileCheck %s<br class="">+define void @tester(){<br class="">+ ret void<br class="">+}<br class="">+<br class="">+define void @foo(){<br class="">+ ret void<br class="">+}<br class="">+<br class="">+;CHECK: IR Dump After Promote Memory to Register<br class="">+;CHECK: IR Dump After Combine redundant instructions<br class="">+;CHECK: IR Dump After Module Verifier<br class="">+;CHECK-NOT: IR Dump After Print Module IR<br class=""><br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">I'm afraid this will break, as CHECK-NOT(s) are really fragile. Is there</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">a better way we can test this? probably `CHECK-NEXT` & adding a "end</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">of pipeline" message?</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div><div>I agree, that seems better. Son, can you take a care of that?</div><br class=""><blockquote type="cite" class=""><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">--</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Davide</span></div></blockquote></div><br class=""></body></html>