<div dir="ltr">Hi Mark,<br><br><div class="gmail_quote"><div dir="ltr">Il giorno lun 9 lug 2018 alle ore 19:20 Mark Searles <<a href="mailto:m.c.searles@gmail.com">m.c.searles@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Mauro,</div><div><br></div><div></div><div><a href="https://reviews.llvm.org/D49089" target="_blank">https://reviews.llvm.org/D49089</a> . Incidentally, do you have a phab userID? I tried to find it so that I could add you to the review, but no luck. No problem if you don't.<br></div></div></blockquote><div><br></div><div>I do not have phab userID</div><div>KR</div><div>Mauro</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div><br></div><div>Thanks for your efforts on this (reporting/suggesting fix/etc.); much appreciated.<br></div><div></div><br><div>Mark<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 9, 2018 at 9:39 AM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Mark,<div>no problem</div><div><br></div><div>Pardon me, if I may have contacted wrong people or in the wrong way,</div><div>because I am not familiar with your proceedings</div><div>and please review it because I've very basic coding skills,</div><div>which gives the worst combination possible :-)</div><div>Kind regards</div><div><br></div><div>Mauro</div><div><br></div><div><br></div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">Il giorno lun 9 lug 2018 alle ore 17:37 Mark Searles <<a href="mailto:m.c.searles@gmail.com" target="_blank">m.c.searles@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Mauro,<br></div><div><br></div><div>Sorry, I thought you just wanted a review from me, not for me to submit the patch itself. Perhaps that was a wrong assumption. I will submit the patch; give me a day or two.<br></div><div><br></div><div>Thanks,<br></div><div><br></div><div>Mark<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 8, 2018 at 1:23 PM Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><br><div class="gmail_quote"><div dir="ltr">Il giorno lun 11 giu 2018 alle ore 18:01 Mark Searles <<a href="mailto:m.c.searles@gmail.com" target="_blank">m.c.searles@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>LGTM</div><div><br></div><div>Mark<br></div></div></blockquote><div><br></div><div>Could you please check if the patch has been applied?</div><div><br></div><div>With llvm-mirrors/master branch the building error is still happening with Android and also in stable branch</div><div>and the commit is necessary to avoid the building error.</div><div>Kind regards</div><div><br></div><div>Mauro</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 11, 2018 at 12:06 AM Hans Wennborg <<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">- llvm-dev, +llvm-commits<br>
<br>
Mark, this looks like your code. Can you take a look?<br>
<br>
<br>
On Sun, Jun 10, 2018 at 3:34 PM, Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote:<br>
> Fixes the following building error:<br>
><br>
> external/llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1903:61:<br>
> error: comparison of integers of different signs:<br>
> 'typename iterator_traits<__wrap_iter<MachineBasicBlock **> >::difference_type'<br>
> (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]<br>
> BlockWaitcntProcessedSet.end(), &MBB) < Count)) {<br>
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~<br>
> 1 error generated.<br>
><br>
> Fixes: 4f520606fc ("[AMDGPU] Do not only rely on BB number when finding bottom loop")<br>
> ---<br>
> lib/Target/AMDGPU/SIInsertWaitcnts.cpp | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/lib/Target/AMDGPU/SIInsertWaitcnts.cpp b/lib/Target/AMDGPU/SIInsertWaitcnts.cpp<br>
> index fb24d528c33..c3c93cc85e2 100644<br>
> --- a/lib/Target/AMDGPU/SIInsertWaitcnts.cpp<br>
> +++ b/lib/Target/AMDGPU/SIInsertWaitcnts.cpp<br>
> @@ -1900,7 +1900,7 @@ bool SIInsertWaitcnts::runOnMachineFunction(MachineFunction &MF) {<br>
> // If the loop has multiple back-edges, and so more than one "bottom"<br>
> // basic block, we have to guarantee a re-walk over every blocks.<br>
> if ((std::count(BlockWaitcntProcessedSet.begin(),<br>
> - BlockWaitcntProcessedSet.end(), &MBB) < Count)) {<br>
> + BlockWaitcntProcessedSet.end(), &MBB) < (int) Count)) {<br>
> BlockWaitcntBracketsMap[&MBB]->setRevisitLoop(true);<br>
> LLVM_DEBUG(dbgs() << "set-revisit1: Block"<br>
> << ContainingLoop->getHeader()->getNumber() << '\n';);<br>
> --<br>
> 2.17.1<br>
><br>
</blockquote></div>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div></div>