<div dir="ltr">Should that be by const ref? It doesn't seem like a "verify" option should be mutating anything?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 29, 2018 at 12:22 PM Paul Robinson via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: probinson<br>
Date: Fri Jun 29 12:17:44 2018<br>
New Revision: 336007<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=336007&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=336007&view=rev</a><br>
Log:<br>
Pass DWARFUnit to verifier by reference not by value.  I am moderately<br>
sure this should not cause a memory leak.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h<br>
    llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h?rev=336007&r1=336006&r2=336007&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h?rev=336007&r1=336006&r2=336007&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h (original)<br>
+++ llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h Fri Jun 29 12:17:44 2018<br>
@@ -152,7 +152,7 @@ private:<br>
   ///                  type of the unit DIE.<br>
   ///<br>
   /// \returns true if the content is verified successfully, false otherwise.<br>
-  bool verifyUnitContents(DWARFUnit Unit, uint8_t UnitType = 0);<br>
+  bool verifyUnitContents(DWARFUnit &Unit, uint8_t UnitType = 0);<br>
<br>
   /// Verify that all Die ranges are valid.<br>
   ///<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp?rev=336007&r1=336006&r2=336007&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp?rev=336007&r1=336006&r2=336007&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp Fri Jun 29 12:17:44 2018<br>
@@ -171,7 +171,7 @@ bool DWARFVerifier::verifyUnitHeader(con<br>
   return Success;<br>
 }<br>
<br>
-bool DWARFVerifier::verifyUnitContents(DWARFUnit Unit, uint8_t UnitType) {<br>
+bool DWARFVerifier::verifyUnitContents(DWARFUnit &Unit, uint8_t UnitType) {<br>
   uint32_t NumUnitErrors = 0;<br>
   unsigned NumDies = Unit.getNumDIEs();<br>
   for (unsigned I = 0; I < NumDies; ++I) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>