<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 6/28/2018 2:25 PM, Zachary Turner
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAAErz9jhA=jDNZhjLTaxG6s9tqetdXcCDnRfrn7vPF=EXhvAmg@mail.gmail.com">
<div dir="ltr">I'm using the mono-repo, not git svn.</div>
</blockquote>
<br>
You're using the git-llvm script to commit? I wouldn't be surprised
if there's a bug in it. Looks like it's trying to pass the commit
message on the command-line; that's guaranteed to fail with python2.<br>
<br>
<blockquote type="cite"
cite="mid:CAAErz9jhA=jDNZhjLTaxG6s9tqetdXcCDnRfrn7vPF=EXhvAmg@mail.gmail.com">
<div dir="ltr"> Is it possible that since I did a copy/paste
operation, it actually pasted Windows-1252 encoded text into the
commit message (default encoding for a console terminal), but it
looked fine to me because my console correctly interepreted it?</div>
</blockquote>
<br>
Windows consoles can be weird... I mean, in theory, a well-behaved
program should use the Unicode APIs to write to the console, but I
don't know what the version of git you're using does. But you could
check that pretty easily: does the munged text in your console match
the munged text in this email?<br>
<br>
-Eli<br>
<br>
<blockquote type="cite"
cite="mid:CAAErz9jhA=jDNZhjLTaxG6s9tqetdXcCDnRfrn7vPF=EXhvAmg@mail.gmail.com">
<div dir="ltr">
<div><br>
</div>
<div>AFter doing a pull and doing git log again, it looks munged
on my side.</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Jun 28, 2018 at 2:16 PM Friedman, Eli
<<a href="mailto:efriedma@codeaurora.org"
moz-do-not-send="true">efriedma@codeaurora.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_-4920843579140595975moz-cite-prefix">Both git
and svn commit messages are UTF-8, so probably something
happened on your computer. Maybe a bug in the version of
git-svn you're using?</div>
</div>
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_-4920843579140595975moz-cite-prefix"><br>
<br>
-Eli</div>
</div>
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_-4920843579140595975moz-cite-prefix"><br>
<br>
On 6/28/2018 2:02 PM, Zachary Turner wrote:<br>
</div>
</div>
<div text="#000000" bgcolor="#FFFFFF">
<blockquote type="cite">
<div dir="ltr">That's odd. I went here (<a
href="https://reviews.llvm.org/p/mkoeppen/"
target="_blank" moz-do-not-send="true">https://reviews.llvm.org/p/mkoeppen/</a>),
Ctrl+C'ed on his name, Ctrl+V'ed into the git commit
window, and then submit. After committing, when I did
git log it showed up correctly for me. I guess it got
munged somewhere between git, svn, and the master
repository.</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Jun 28, 2018 at 2:00 PM Friedman,
Eli <<a href="mailto:efriedma@codeaurora.org"
target="_blank" moz-do-not-send="true">efriedma@codeaurora.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">On
6/28/2018 1:09 PM, Zachary Turner via llvm-commits
wrote:<br>
> Author: zturner<br>
> Date: Thu Jun 28 13:09:37 2018<br>
> New Revision: 335915<br>
><br>
> URL: <a
href="http://llvm.org/viewvc/llvm-project?rev=335915&view=rev"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://llvm.org/viewvc/llvm-project?rev=335915&view=rev</a><br>
> Log:<br>
> Fix padding with custom character in formatv.<br>
><br>
> The format string for formatv allows to specify a
custom padding<br>
> character instead of the default space. This
custom character was<br>
> parsed correctly, but not passed on to the
formatter.<br>
><br>
> Patch by Marcel Köppe<br>
<br>
I assume that's supposed to be "Marcel Köppen".<br>
<br>
I'm curious, how did you manage to get "Köppe" into
the commit <br>
message? It looks like UTF-8 text was incorrectly
interpreted as <br>
windows-1252 in at least two separate places.<br>
<br>
-Eli<br>
<br>
-- <br>
Employee of Qualcomm Innovation Center, Inc.<br>
Qualcomm Innovation Center, Inc. is a member of Code
Aurora Forum, a Linux Foundation Collaborative Project<br>
<br>
</blockquote>
</div>
</blockquote>
<p><br>
</p>
<pre class="m_-4920843579140595975moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</div>
</blockquote>
</div>
</blockquote>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>