<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Tim,</p>
<p style="margin-top:0;margin-bottom:0">Thanks for pointing that out, I agree, shall revert that specific case and fix.</p>
<p style="margin-top:0;margin-bottom:0">Thanks</p>
<p style="margin-top:0;margin-bottom:0">Luke</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Tim Northover <t.p.northover@gmail.com><br>
<b>Sent:</b> 27 June 2018 14:59:54<br>
<b>To:</b> Luke Geeson<br>
<b>Cc:</b> LLVM Commits<br>
<b>Subject:</b> Re: [llvm] r335715 - [AArch64] Remove Duplicate FP16 Patterns with same encoding, match on existing patterns</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Luke,<br>
<br>
On Wed, 27 Jun 2018 at 10:24, Luke Geeson via llvm-commits<br>
<llvm-commits@lists.llvm.org> wrote:<br>
> define dso_local half @test_vcvth_n_f16_s64_1(i64 %a) {<br>
> ; CHECK-LABEL: test_vcvth_n_f16_s64_1:<br>
> ; CHECK: fmov d0, x0<br>
> -; CHECK-NEXT: fcvtzs h0, d0, #1<br>
> +; CHECK-NEXT: scvtf h0, h0, #1<br>
> ; CHECK-NEXT: ret<br>
> entry:<br>
> %vcvth_n_f16_s64 = tail call half @llvm.aarch64.neon.vcvtfxs2fp.f16.i64(i64 %a, i32 1)<br>
<br>
This doesn't look right to me. We're discarding the high bits of %a<br>
before doing the conversion.<br>
<br>
I suspect only the i16 versions would ever want to use these patterns<br>
anyway (since "scvtf h0, x0, #1" exists).<br>
<br>
Cheers.<br>
<br>
Tim.<br>
</div>
</span></font></div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>