<div dir="ltr">This should be labelled NFCI as TokenFactor cleanups do not change the dependencies directly.<div>They only indirectly enable other optimizations which are already disabled for optnone. <br></div><div><br></div><div>-Nirav</div><div><div><br></div><div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 27, 2018 at 3:52 PM, Roman Lebedev <span dir="ltr"><<a href="mailto:lebedev.ri@gmail.com" target="_blank">lebedev.ri@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Test?<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Jun 27, 2018 at 10:41 PM, Nirav Dave via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: niravd<br>
> Date: Wed Jun 27 12:41:25 2018<br>
> New Revision: 335773<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=335773&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=335773&view=rev</a><br>
> Log:<br>
> [DAGCombine] Disable TokenFactor simplifications when optnone.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=335773&r1=335772&r2=335773&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>CodeGen/SelectionDAG/<wbr>DAGCombiner.cpp?rev=335773&r1=<wbr>335772&r2=335773&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp Wed Jun 27 12:41:25 2018<br>
> @@ -1692,6 +1692,10 @@ SDValue DAGCombiner::visitTokenFactor(<wbr>SD<br>
>        return N->getOperand(1);<br>
>    }<br>
><br>
> +  // Don't simplify token factors if optnone.<br>
> +  if (OptLevel == CodeGenOpt::None)<br>
> +    return SDValue();<br>
> +<br>
>    SmallVector<SDNode *, 8> TFs;     // List of token factors to visit.<br>
>    SmallVector<SDValue, 8> Ops;      // Ops for replacing token factor.<br>
>    SmallPtrSet<SDNode*, 16> SeenOps;<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>