<div dir="ltr">Hi Douglas,<div><br></div><div>I will take a look and probably just remove the default case.</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 26, 2018 at 1:21 AM <<a href="mailto:douglas.yung@sony.com">douglas.yung@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Matt,<br>
<br>
Our internal bot started to fail after your commit because we build with -Werror and two warnings from the googletest framework are causing it to fail.<br>
<br>
FAILED: cd /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/lib/fuzzer/tests && /home/siadmin/jenkins/w/opensource/opensource_build/build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unknown-warning-option -DGTEST_NO_LLVM_RAW_OSTREAM=1 -DGTEST_HAS_RTTI=0 -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/include -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest -I/home/siadmin/jenkins/w/opensource/opensource_build/llvm/projects/compiler-rt/lib/fuzzer -fno-rtti -Werror -O2 -m64 -c -o FuzzerTestObjects.gtest-all.cc.x86_64.o /home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-all.cc<br>
In file included from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-all.cc:42:<br>
/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest.cc:2842:5: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]<br>
    default:<br>
    ^<br>
In file included from /home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-all.cc:43:<br>
/home/siadmin/jenkins/w/opensource/opensource_build/llvm/utils/unittest/googletest/src/gtest-death-test.cc:581:5: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]<br>
    default:<br>
    ^<br>
2 errors generated.<br>
<br>
Can you take a look? I think the fix would be to specify that -Werror is not used when building your tests. For example, in the same build that failed, I see identical warnings from building sanitizer tests that do not get promoted to an error.<br>
<br>
Douglas Yung<br>
<br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On<br>
> Behalf Of Matt Morehouse via llvm-commits<br>
> Sent: Monday, June 25, 2018 13:30<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: [compiler-rt] r335519 - [CMake] Run libFuzzer tests with<br>
> check-all.<br>
> <br>
> Author: morehouse<br>
> Date: Mon Jun 25 13:30:03 2018<br>
> New Revision: 335519<br>
> <br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=335519&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=335519&view=rev</a><br>
> Log:<br>
> [CMake] Run libFuzzer tests with check-all.<br>
> <br>
> Reviewers: kcc<br>
> <br>
> Reviewed By: kcc<br>
> <br>
> Subscribers: llvm-commits, mgorny<br>
> <br>
> Differential Revision: <a href="https://reviews.llvm.org/D48200" rel="noreferrer" target="_blank">https://reviews.llvm.org/D48200</a><br>
> <br>
> Modified:<br>
>     compiler-rt/trunk/test/fuzzer/CMakeLists.txt<br>
> <br>
> Modified: compiler-rt/trunk/test/fuzzer/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-</a><br>
> rt/trunk/test/fuzzer/CMakeLists.txt?rev=335519&r1=335518&r2=335519&view<br>
> =diff<br>
> =======================================================================<br>
> =======<br>
> --- compiler-rt/trunk/test/fuzzer/CMakeLists.txt (original)<br>
> +++ compiler-rt/trunk/test/fuzzer/CMakeLists.txt Mon Jun 25 13:30:03<br>
> 2018<br>
> @@ -11,8 +11,6 @@ if(COMPILER_RT_INCLUDE_TESTS)<br>
>    list(APPEND LIBFUZZER_TEST_DEPS FuzzerUnitTests)<br>
>  endif()<br>
> <br>
> -set(EXCLUDE_FROM_ALL ON)<br>
> -<br>
>  add_custom_target(check-fuzzer)<br>
> <br>
>  if(COMPILER_RT_INCLUDE_TESTS)<br>
> <br>
> <br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>