<div dir="ltr">Could the getSDValue call be rolled into the assert? (to avoid doing the work of that function call when assertions are enabled) Or does it have necessary side effects that must occur even in a nonasserts build? (functions name 'get' with side effects are a bit misleading, though not all that uncommon)</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 14, 2018 at 8:59 AM Nirav Dave via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: niravd<br>
Date: Thu Jun 14 08:55:15 2018<br>
New Revision: 334731<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=334731&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=334731&view=rev</a><br>
Log:<br>
Avoid unused variable in non-assert builds.<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp?rev=334731&r1=334730&r2=334731&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp?rev=334731&r1=334730&r2=334731&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp Thu Jun 14 08:55:15 2018<br>
@@ -105,6 +105,7 @@ void DAGTypeLegalizer::PerformExpensiveC<br>
           I = ReplacedValues.find(NewValId);<br>
         }<br>
         SDValue NewVal = getSDValue(NewValId);<br>
+        (void)NewVal;<br>
         assert(NewVal.getNode()->getNodeId() != NewNode &&<br>
                "ReplacedValues maps to a new node!");<br>
       }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>