<div dir="ltr">I should add,
<span style="text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">r334543<span> was reverted in r</span></span>334566, and the buildbot went green:<br><div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/</a><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jun 13, 2018 at 11:58 AM Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It's more likely that r334543 enabled building the intel jit event code in the first place. I think the null check is still correct and we should keep it. There are no owned raw pointers here, everything is handled with RAII.<br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 12, 2018 at 5:26 PM Matt Morehouse <<a href="mailto:mascasa@google.com" target="_blank">mascasa@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This appears to have caused a memory leak: <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/19431" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/19431</a><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 12, 2018 at 1:58 PM Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Tue Jun 12 13:54:11 2018<br>
New Revision: 334544<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=334544&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=334544&view=rev</a><br>
Log:<br>
Add null check to Intel JIT event listener<br>
<br>
Modified:<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp?rev=334544&r1=334543&r2=334544&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp?rev=334544&r1=334543&r2=334544&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp Tue Jun 12 13:54:11 2018<br>
@@ -101,15 +101,17 @@ void IntelJITEventListener::NotifyObject<br>
const RuntimeDyld::LoadedObjectInfo &L) {<br>
<br>
OwningBinary<ObjectFile> DebugObjOwner = L.getObjectForDebug(Obj);<br>
- const ObjectFile &DebugObj = *DebugObjOwner.getBinary();<br>
+ const ObjectFile *DebugObj = DebugObjOwner.getBinary();<br>
+ if (!DebugObj)<br>
+ return;<br>
<br>
// Get the address of the object image for use as a unique identifier<br>
- const void* ObjData = DebugObj.getData().data();<br>
- std::unique_ptr<DIContext> Context = DWARFContext::create(DebugObj);<br>
+ const void* ObjData = DebugObj->getData().data();<br>
+ std::unique_ptr<DIContext> Context = DWARFContext::create(*DebugObj);<br>
MethodAddressVector Functions;<br>
<br>
// Use symbol info to iterate functions in the object.<br>
- for (const std::pair<SymbolRef, uint64_t> &P : computeSymbolSizes(DebugObj)) {<br>
+ for (const std::pair<SymbolRef, uint64_t> &P : computeSymbolSizes(*DebugObj)) {<br>
SymbolRef Sym = P.first;<br>
std::vector<LineNumberInfo> LineInfo;<br>
std::string SourceFileName;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>