<div dir="ltr"><div>Thanks, good catch. It was just a quick fix to appease the bots.</div><div><br></div>Here's a much nicer implementation: <a href="https://reviews.llvm.org/D48070">https://reviews.llvm.org/D48070</a><br><div><br></div><div>Cheers!</div></div><br><div class="gmail_quote"><div dir="ltr">Am Mo., 11. Juni 2018 um 23:52 Uhr schrieb David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">const by-value return types tend to inhibit optimizations (means the return value can't be moved-from or have non-const operations called on it) - did you mean const string ref return type? (or plain non-const value return type?)</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 7, 2018 at 12:55 AM Philip Pfaffe via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pfaffe<br>
Date: Thu Jun  7 00:50:55 2018<br>
New Revision: 334166<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=334166&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=334166&view=rev</a><br>
Log:<br>
Fix a missing lambda return type that tripped the builders<br>
<br>
Modified:<br>
    polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp<br>
<br>
Modified: polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp?rev=334166&r1=334165&r2=334166&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp?rev=334166&r1=334165&r2=334166&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp (original)<br>
+++ polly/trunk/lib/CodeGen/PPCGCodeGeneration.cpp Thu Jun  7 00:50:55 2018<br>
@@ -1408,7 +1408,7 @@ const std::map<std::string, std::string><br>
 ///<br>
 /// Return "" if we are not compiling for CUDA.<br>
 std::string getCUDALibDeviceFuntion(Function *F) {<br>
-  const std::string FnName = [&] {<br>
+  auto FnName = [&] () -> const std::string {<br>
     auto It = IntrinsicToLibdeviceFunc.find(F->getName());<br>
     if (It != IntrinsicToLibdeviceFunc.end())<br>
       return It->second;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>