<div dir="ltr">We can add feature predicatse to these if it helps. Not sure what you meant by "like a of AVX512"? What else in AVX512 doesn't have flags?<br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div><br></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 11, 2018 at 10:32 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br>
Date: Mon Jun 11 10:28:00 2018<br>
New Revision: 334423<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=334423&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=334423&view=rev</a><br>
Log:<br>
[X86][AVX512] Tag AVX5124FMAPS/AVX5124VNNIW with missing scheduler classes<br>
<br>
Necessary for D46276 as even though btver2 doesn't use these instructions, its now flagged as complete so complains if ANY instruction isn't tagged.....<br>
<br>
UnsupportedFeatures wouldn't help here as these instructions don't appear to have a feature predicate (like a lot of AVX512).<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86InstrAVX512.td<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86InstrAVX512.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrAVX512.td?rev=334423&r1=334422&r2=334423&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrAVX512.td?rev=334423&r1=334422&r2=334423&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86InstrAVX512.td (original)<br>
+++ llvm/trunk/lib/Target/X86/X86InstrAVX512.td Mon Jun 11 10:28:00 2018<br>
@@ -11333,22 +11333,26 @@ let hasSideEffects = 0, mayLoad = 1, Exe<br>
 defm V4FMADDPSrm : AVX512_maskable_3src_in_asm<0x9A, MRMSrcMem, v16f32_info,<br>
                     (outs VR512:$dst), (ins VR512:$src2, f128mem:$src3),<br>
                     "v4fmaddps", "$src3, $src2", "$src2, $src3",<br>
-                    []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>;<br>
+                    []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>,<br>
+                    Sched<[SchedWriteFMA.ZMM.Folded]>;<br>
<br>
 defm V4FNMADDPSrm : AVX512_maskable_3src_in_asm<0xAA, MRMSrcMem, v16f32_info,<br>
                      (outs VR512:$dst), (ins VR512:$src2, f128mem:$src3),<br>
                      "v4fnmaddps", "$src3, $src2", "$src2, $src3",<br>
-                     []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>;<br>
+                     []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>,<br>
+                     Sched<[SchedWriteFMA.ZMM.Folded]>;<br>
<br>
 defm V4FMADDSSrm : AVX512_maskable_3src_in_asm<0x9B, MRMSrcMem, f32x_info,<br>
                     (outs VR128X:$dst), (ins  VR128X:$src2, f128mem:$src3),<br>
                     "v4fmaddss", "$src3, $src2", "$src2, $src3",<br>
-                    []>, EVEX_V128, EVEX_4V, T8XD, EVEX_CD8<32, CD8VF>;<br>
+                    []>, EVEX_V128, EVEX_4V, T8XD, EVEX_CD8<32, CD8VF>,<br>
+                    Sched<[SchedWriteFMA.Scl.Folded]>;<br>
<br>
 defm V4FNMADDSSrm : AVX512_maskable_3src_in_asm<0xAB, MRMSrcMem, f32x_info,<br>
                      (outs VR128X:$dst), (ins VR128X:$src2, f128mem:$src3),<br>
                      "v4fnmaddss", "$src3, $src2", "$src2, $src3",<br>
-                     []>, EVEX_V128, EVEX_4V, T8XD, EVEX_CD8<32, CD8VF>;<br>
+                     []>, EVEX_V128, EVEX_4V, T8XD, EVEX_CD8<32, CD8VF>,<br>
+                     Sched<[SchedWriteFMA.Scl.Folded]>;<br>
 }<br>
<br>
 //===----------------------------------------------------------------------===//<br>
@@ -11360,11 +11364,13 @@ let hasSideEffects = 0, mayLoad = 1, Exe<br>
 defm VP4DPWSSDrm : AVX512_maskable_3src_in_asm<0x52, MRMSrcMem, v16i32_info,<br>
                     (outs VR512:$dst), (ins VR512:$src2, f128mem:$src3),<br>
                      "vp4dpwssd", "$src3, $src2", "$src2, $src3",<br>
-                    []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>;<br>
+                    []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>,<br>
+                    Sched<[SchedWriteFMA.ZMM.Folded]>;<br>
<br>
 defm VP4DPWSSDSrm : AVX512_maskable_3src_in_asm<0x53, MRMSrcMem, v16i32_info,<br>
                      (outs VR512:$dst), (ins VR512:$src2, f128mem:$src3),<br>
                      "vp4dpwssds", "$src3, $src2", "$src2, $src3",<br>
-                     []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>;<br>
+                     []>, EVEX_V512, EVEX_4V, T8XD, EVEX_CD8<32, CD8VQ>,<br>
+                     Sched<[SchedWriteFMA.ZMM.Folded]>;<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>