<div dir="ltr">The author has made this change upstream for version 4 of SimpleMOC.<br><div class="gmail_extra"><br></div><div class="gmail_extra">Brian</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 16, 2018 at 5:16 AM, Hal Finkel <span dir="ltr"><<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<p><br>
</p>
<div class="m_1353262510852830639moz-cite-prefix">On 05/15/2018 04:37 PM, Brian Homerding
via llvm-commits wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">I have spoken to John about the UB. He asked if we
wanted the change upstream also and I had left it up to him. If
this is a concern I will follow up on making the change upstream
as well.</div>
</blockquote>
<br></span>
We should, to the extent possible, have these changes made upstream
as well.<br>
<br>
-Hal<br>
<br>
<blockquote type="cite"><span class="">
<div dir="ltr">
<div><br>
</div>
<div>Brian</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, May 15, 2018 at 3:49 PM, Davide
Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Tue, May 15, 2018 at 1:42 PM, Brian Homerding
via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>
wrote:<br>
> Author: homerdin<br>
> Date: Tue May 15 13:42:38 2018<br>
> New Revision: 332395<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=332395&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=332395&view=rev</a><br>
> Log:<br>
> [test-suite][ubsan] Remove optimization that causes
UB in SimpleMOC.<br>
><br>
> This patch replaces the hand written ceil() with a
call to ceilf(). This small<br>
> optimization is outside the primary kernel and should
show little to no<br>
> difference in performance for the test suite.
Previously the UB was only used<br>
> in an '==' comparison for an early exit from the loop
and had no effect on the<br>
> program behavior.<br>
><br>
<br>
</span>Have you considered making this change upstream and
back porting? I'd<br>
rather not create unnecessary divergencies, if possible.<br>
<a href="https://github.com/ANL-CESAR/SimpleMOC" rel="noreferrer" target="_blank">https://github.com/ANL-CESAR/S<wbr>impleMOC</a><br>
<br>
--<br>
Davide<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="m_1353262510852830639mimeAttachmentHeader"></fieldset>
<br>
</span><span class=""><pre>______________________________<wbr>_________________
llvm-commits mailing list
<a class="m_1353262510852830639moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>
<a class="m_1353262510852830639moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a>
</pre>
</span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<pre class="m_1353262510852830639moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</font></span></div>
</blockquote></div><br></div></div>