<div dir="ltr"><div>Hi Aaron,</div><div><br></div><div>Sorry about that. I will look into it.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 27, 2018 at 3:00 PM, Aaron Ballman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, May 25, 2018 at 2:25 PM, Andrea Di Biagio via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: adibiagio<br>
> Date: Fri May 25 11:25:54 2018<br>
> New Revision: 333293<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=333293&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=333293&view=rev</a><br>
> Log:<br>
> [Tablegen][SubtargetEmitter] Add a default case to the auto-generated switch in MCSubtargetInfo::<wbr>resolveVariantSchedClass(). NFC<br>
><br>
> Modified:<br>
>     llvm/trunk/utils/TableGen/<wbr>SubtargetEmitter.cpp<br>
><br>
> Modified: llvm/trunk/utils/TableGen/<wbr>SubtargetEmitter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/SubtargetEmitter.cpp?rev=333293&r1=333292&r2=333293&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/utils/<wbr>TableGen/SubtargetEmitter.cpp?<wbr>rev=333293&r1=333292&r2=<wbr>333293&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/utils/TableGen/<wbr>SubtargetEmitter.cpp (original)<br>
> +++ llvm/trunk/utils/TableGen/<wbr>SubtargetEmitter.cpp Fri May 25 11:25:54 2018<br>
> @@ -1556,7 +1556,9 @@ void SubtargetEmitter::<wbr>emitSchedModelHel<br>
>          OS << "    return " << SC.Index << ";\n";<br>
>        OS << "    break;\n";<br>
>      }<br>
> -    OS << "  };\n";<br>
> +    // Add a default case to avoid generating a potentially empty switch.<br>
> +    OS << "  default : break;\n"<br>
> +       << "  };\n";<br>
>    }<br>
<br>
</span>This is now generating MSVC diagnostics about switch statements<br>
containing no case labels and only a default label. Can you please<br>
reformulate this commit to not generate the switch statement at all?<br>
<br>
~Aaron<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
>    if (OnlyExpandMCInstPredicates) {<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>