<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 25 May 2018, at 03:45, Nicola Zaghen <<a href="mailto:nicola.zaghen@imgtec.com" class="">nicola.zaghen@imgtec.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<div text="#000000" bgcolor="#FFFFFF" class=""><p class="">Hi Daniel,<br class="">
<br class="">
The removal was discussed on the mailing list back in March
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/pipermail/llvm-dev/2018-March/122097.html">http://lists.llvm.org/pipermail/llvm-dev/2018-March/122097.html</a>,
but you make a good point: an email to let people know that the
change is actually in and with some instructions would be a good
thing to do. I'll look into it now.<br class=""></p></div></div></blockquote><div>Ah, ok. I must have missed it while I was catching up after GDC.</div><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class=""><p class="">
Regarding the quick replace -> remove, this was also part of
the email (and also the review of the change). It was done so
quickly because every day people would add new uses of the DEBUG()
macro as it would have kept working the same way, which would then
left us with two equivalent macros for a long time.<br class=""></p></div></div></blockquote>I agree that if it's there and usable then it will sneak back in. We could potentially have made the old macro emit deprecation warnings. It's not possible to mark a macro as being deprecated but it's possible to make it call a deprecated function like so:<br class=""><div style="margin: 0px; font-stretch: normal; font-size: 11px; line-height: normal; font-family: Menlo; color: rgb(255, 255, 255); background-color: rgb(0, 0, 0);" class=""><div style="margin: 0px; font-stretch: normal; line-height: normal;" class=""><div style="margin: 0px; font-stretch: normal; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">diff --git a/include/llvm/Support/Debug.h b/include/llvm/Support/Debug.h</b></span></div><div style="margin: 0px; font-stretch: normal; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">index 980abfb0e8d..86c6131604d 100644</b></span></div><div style="margin: 0px; font-stretch: normal; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">--- a/include/llvm/Support/Debug.h</b></span></div><div style="margin: 0px; font-stretch: normal; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><b class="">+++ b/include/llvm/Support/Debug.h</b></span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(46, 174, 187);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">@@ -29,6 +29,8 @@</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> #ifndef LLVM_SUPPORT_DEBUG_H</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> #define LLVM_SUPPORT_DEBUG_H</span></div><p style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241); min-height: 13px;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> </span><br class="webkit-block-placeholder"></p><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+#include "llvm/Support/Compiler.h"</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> namespace llvm {</span></div><p style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241); min-height: 13px;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> </span><br class="webkit-block-placeholder"></p><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> class raw_ostream;</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures; color: #2eaebb" class="">@@ -118,6 +120,9 @@</span><span style="font-variant-ligatures: no-common-ligatures" class=""> raw_ostream &dbgs();</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> //</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> #define LLVM_DEBUG(X) DEBUG_WITH_TYPE(DEBUG_TYPE, X)</span></div><p style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241); min-height: 13px;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> </span><br class="webkit-block-placeholder"></p><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+LLVM_ATTRIBUTE_DEPRECATED(void deprecate_debug_macro(), "Use LLVM_DEBUG instead");</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+#define DEBUG(X) do { deprecate_debug_macro(); LLVM_DEBUG(X); } while(false)</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(47, 180, 29);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+</span></div><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> } // end namespace llvm</span></div><p style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241); min-height: 13px;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> </span><br class="webkit-block-placeholder"></p><div style="margin: 0px; font-stretch: normal; line-height: normal; color: rgb(241, 241, 241);" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> #endif // LLVM_SUPPORT_DEBUG_H</span></div></div></div><div>I don't think it makes sense to re-introduce it in order to deprecate it though.</div><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class=""><p class="">
With regards to the sed command I provided, I thought sed would be
"fairly recent" on all systems, but it seems like the version
shipped with macOS is quite dated (or at least lacks features).<br class=""></p></div></div></blockquote><div>It's a BSD sed so it lacks quite a few things from GNU sed. I run into quirks like this fairly often. I found the mandatory argument to -i particularly confusing when I first encountered it :-)</div><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class=""><p class="">
I tried rewriting it with awk but I had the same issue.<br class="">
Currently I have this perl one which worked fine on both Linux
(Ubuntu 16.04) and macOS 10.13 with a fresh git clone of
llvm-mirror. <br class="">
<br class="">
git grep -l 'DEBUG' | xargs perl -pi -e
's/\bDEBUG\s?\(/LLVM_DEBUG(/g'<br class="">
<br class="">
Can you test it out and let me know if it works for you? I'd like
to have one that works on multiple platforms so I can eventually
update the release notes and email llvm-dev with it (in the
"change has been completed" email).<br class=""></p></div></div></blockquote>That works for me. Using that and the clang-format command, I get the same result as I did with the macOS sed command.</div><div><br class=""></div><div>Thanks<br class=""><blockquote type="cite" class=""><div class=""><div text="#000000" bgcolor="#FFFFFF" class=""><p class="">
<br class="">
Thanks,<br class="">
Nicola<br class="">
</p>
<br class="">
<div class="moz-cite-prefix">On 24/05/18 17:43, Daniel Sanders
wrote:<br class="">
</div>
<blockquote type="cite" cite="mid:5CE9302B-423A-49EA-A622-24CE5D7C960A@apple.com" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
Hi Nicola,
<div class=""><br class="">
</div>
<div class="">This removal should get an email on llvm-dev and a
mention in the release notes since there's a lot of out-of-tree
projects that are going to be broken by this change and won't
have noticed the llvm-commits post. In my case I can't find the
earlier commits that added LLVM_DEBUG in my mailbox so I'm not
sure what happened there, maybe it was filtered out for being
too large. Some projects will notice when they're pulling the
trunk into their downstream repo's (like we did :-) ) but there
will also be another wave when we do the next release as there's
also out of tree targets that don't closely track trunk.</div>
<div class=""><br class="">
</div>
<div class="">It's also worth mentioning the merge pain that the
very quick removal is going to cause. I'm reluctant to mention
this since I believe it isn't LLVM's responsibility to account
for it (it's ours) but this case is a bit special in that it's
likely to hit an unusually large number of merges over the next
few years. As bugs are fixed in existing releases, it's common
to merge those fixes into the current code-base so that the bugs
aren't introduced again. Effectively that means that some
branches are using DEBUG() and others are using LLVM_DEBUG() and
the practical result of this is that any merges containing or
near lines with the DEBUG() macro are going result in merge
conflicts. Probably the least painful way to resolve it is to
re-introduce DEBUG() locally but I don't like that solution
because we'll never make the switch. Unfortunately making the
switch on all branches probably isn't an option either. I'm
going to have a think on how best to deal with this.</div>
<div class=""><br class="">
</div>
<div class="">By the way, the sed command from your earlier commit
doesn't work on macOS because -i has a mandatory argument and \b
isn't supported. Even with those issues fixed I end up with:</div>
<div class=""><span style="caret-color: rgb(241, 241, 241); color:
rgb(241, 241, 241); font-family: Menlo; font-size: 11px;
background-color: rgb(0, 0, 0);" class="">sed: RE error:
illegal byte sequence</span></div>
<div class=""><br class="">
</div>
<div class="">This seems to work though:</div>
<div class="">
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; color: rgb(241, 241,
241); background-color: rgb(0, 0, 0);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">for
f in $(grep -rlw --exclude-dir=.git 'DEBUG' .);</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; color: rgb(241, 241,
241); background-color: rgb(0, 0, 0);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">do</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; color: rgb(241, 241,
241); background-color: rgb(0, 0, 0);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">
echo $f</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; color: rgb(241, 241,
241); background-color: rgb(0, 0, 0);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">
sed -i '.bak' -e 's/[[:<:]]DEBUG[[:>:]][
\t]*(/LLVM_DEBUG(/g' $f;</span></div>
<div style="margin: 0px; font-stretch: normal; font-size: 11px;
line-height: normal; font-family: Menlo; color: rgb(241, 241,
241); background-color: rgb(0, 0, 0);" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">done</span></div>
</div>
<div class="">
<div class=""><br class="">
</div>
<div class="">
<blockquote type="cite" class="">
<div class="">On 23 May 2018, at 08:09, Nicola Zaghen via
llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="" moz-do-not-send="true">llvm-commits@lists.llvm.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Author: nzaghen<br class="">
Date: Wed May 23 08:09:29 2018<br class="">
New Revision: 333091<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=333091&view=rev" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project?rev=333091&view=rev</a><br class="">
Log:<br class="">
Remove DEBUG macro.<br class="">
<br class="">
Now that the LLVM_DEBUG() macro landed on the various
sub-projects<br class="">
the DEBUG macro can be removed.<br class="">
Also change the new uses of DEBUG to LLVM_DEBUG.<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D46952" class="" moz-do-not-send="true">https://reviews.llvm.org/D46952</a><br class="">
<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIASupport.h<br class="">
llvm/trunk/include/llvm/Support/Debug.h<br class="">
llvm/trunk/lib/Target/X86/X86DomainReassignment.cpp<br class="">
llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp<br class="">
llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp<br class="">
llvm/trunk/lib/Transforms/Vectorize/VPlanVerifier.cpp<br class="">
llvm/trunk/utils/TableGen/GlobalISelEmitter.cpp<br class="">
<br class="">
Modified:
llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIASupport.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIASupport.h?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIASupport.h?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
---
llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIASupport.h
(original)<br class="">
+++
llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIASupport.h
Wed May 23 08:09:29 2018<br class="">
@@ -22,14 +22,6 @@<br class="">
#define NOMINMAX<br class="">
#endif<br class="">
<br class="">
-// llvm/Support/Debug.h unconditionally #defines DEBUG
as a macro.<br class="">
-// DIA headers #define it if it is not already defined,
so we have<br class="">
-// an order of includes problem. The real fix is to
make LLVM use<br class="">
-// something less generic than DEBUG, such as
LLVM_DEBUG(), but it's<br class="">
-// fairly prevalent. So for now, we save the
definition state and<br class="">
-// restore it.<br class="">
-#pragma push_macro("DEBUG")<br class="">
-<br class="">
// atlbase.h has to come before windows.h<br class="">
#include <atlbase.h><br class="">
#include <windows.h><br class="">
@@ -39,6 +31,4 @@<br class="">
#include <dia2.h><br class="">
#include <diacreate.h><br class="">
<br class="">
-#pragma pop_macro("DEBUG")<br class="">
-<br class="">
#endif // LLVM_DEBUGINFO_PDB_DIA_DIASUPPORT_H<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/Support/Debug.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Debug.h?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Debug.h?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/Support/Debug.h (original)<br class="">
+++ llvm/trunk/include/llvm/Support/Debug.h Wed May 23
08:09:29 2018<br class="">
@@ -118,8 +118,6 @@ raw_ostream &dbgs();<br class="">
//<br class="">
#define LLVM_DEBUG(X) DEBUG_WITH_TYPE(DEBUG_TYPE, X)<br class="">
<br class="">
-#define DEBUG(X) LLVM_DEBUG(X)<br class="">
-<br class="">
} // end namespace llvm<br class="">
<br class="">
#endif // LLVM_SUPPORT_DEBUG_H<br class="">
<br class="">
Modified:
llvm/trunk/lib/Target/X86/X86DomainReassignment.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86DomainReassignment.cpp?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86DomainReassignment.cpp?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Target/X86/X86DomainReassignment.cpp
(original)<br class="">
+++ llvm/trunk/lib/Target/X86/X86DomainReassignment.cpp
Wed May 23 08:09:29 2018<br class="">
@@ -753,7 +753,7 @@ bool
X86DomainReassignment::runOnMachine<br class="">
}<br class="">
<br class="">
for (Closure &C : Closures) {<br class="">
- DEBUG(C.dump(MRI));<br class="">
+ LLVM_DEBUG(C.dump(MRI));<br class="">
if (isReassignmentProfitable(C, MaskDomain)) {<br class="">
reassign(C, MaskDomain);<br class="">
++NumClosuresConverted;<br class="">
<br class="">
Modified:
llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp
(original)<br class="">
+++ llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp Wed
May 23 08:09:29 2018<br class="">
@@ -645,8 +645,8 @@ void
MergeFunctions::filterInstsUnrelate<br class="">
static bool isThunkProfitable(Function * F) {<br class="">
if (F->size() == 1) {<br class="">
if (F->front().size() <= 2) {<br class="">
- DEBUG(dbgs() << "isThunkProfitable: "
<< F->getName()<br class="">
- << " is too small to bother
creating a thunk for\n");<br class="">
+ LLVM_DEBUG(dbgs() << "isThunkProfitable: "
<< F->getName()<br class="">
+ << " is too small to
bother creating a thunk for\n");<br class="">
return false;<br class="">
}<br class="">
}<br class="">
<br class="">
Modified:
llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
---
llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
(original)<br class="">
+++
llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
Wed May 23 08:09:29 2018<br class="">
@@ -116,7 +116,7 @@ VPBasicBlock
*PlainCFGBuilder::getOrCrea<br class="">
return BlockIt->second;<br class="">
<br class="">
// Create new VPBB.<br class="">
- DEBUG(dbgs() << "Creating VPBasicBlock for "
<< BB->getName() << "\n");<br class="">
+ LLVM_DEBUG(dbgs() << "Creating VPBasicBlock for
" << BB->getName() << "\n");<br class="">
VPBasicBlock *VPBB = new
VPBasicBlock(BB->getName());<br class="">
BB2VPBB[BB] = VPBB;<br class="">
VPBB->setParent(TopRegion);<br class="">
@@ -314,7 +314,7 @@ void
VPlanHCFGBuilder::buildHierarchical<br class="">
PlainCFGBuilder PCFGBuilder(TheLoop, LI, Plan);<br class="">
VPRegionBlock *TopRegion =
PCFGBuilder.buildPlainCFG();<br class="">
Plan.setEntry(TopRegion);<br class="">
- DEBUG(Plan.setName("HCFGBuilder: Plain CFG\n");
dbgs() << Plan);<br class="">
+ LLVM_DEBUG(Plan.setName("HCFGBuilder: Plain CFG\n");
dbgs() << Plan);<br class="">
<br class="">
Verifier.verifyHierarchicalCFG(TopRegion);<br class="">
}<br class="">
<br class="">
Modified:
llvm/trunk/lib/Transforms/Vectorize/VPlanVerifier.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/VPlanVerifier.cpp?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/VPlanVerifier.cpp?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
---
llvm/trunk/lib/Transforms/Vectorize/VPlanVerifier.cpp
(original)<br class="">
+++
llvm/trunk/lib/Transforms/Vectorize/VPlanVerifier.cpp
Wed May 23 08:09:29 2018<br class="">
@@ -120,7 +120,7 @@ void
VPlanVerifier::verifyHierarchicalCF<br class="">
if (!EnableHCFGVerifier)<br class="">
return;<br class="">
<br class="">
- DEBUG(dbgs() << "Verifying VPlan H-CFG.\n");<br class="">
+ LLVM_DEBUG(dbgs() << "Verifying VPlan
H-CFG.\n");<br class="">
assert(!TopRegion->getParent() && "VPlan
Top Region should have no parent.");<br class="">
verifyRegionRec(TopRegion);<br class="">
}<br class="">
<br class="">
Modified:
llvm/trunk/utils/TableGen/GlobalISelEmitter.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/GlobalISelEmitter.cpp?rev=333091&r1=333090&r2=333091&view=diff" class="" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/GlobalISelEmitter.cpp?rev=333091&r1=333090&r2=333091&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/utils/TableGen/GlobalISelEmitter.cpp
(original)<br class="">
+++ llvm/trunk/utils/TableGen/GlobalISelEmitter.cpp Wed
May 23 08:09:29 2018<br class="">
@@ -4063,7 +4063,7 @@ std::vector<Matcher *>
GlobalISelEmitter<br class="">
}<br class="">
ProcessCurrentGroup();<br class="">
<br class="">
- DEBUG(dbgs() << "NumGroups: " <<
NumGroups << "\n");<br class="">
+ LLVM_DEBUG(dbgs() << "NumGroups: " <<
NumGroups << "\n");<br class="">
assert(CurrentGroup->empty() && "The last
group wasn't properly processed");<br class="">
return OptRules;<br class="">
}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="" moz-do-not-send="true">llvm-commits@lists.llvm.org</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></body></html>