<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"></p>
<div>I think this might have broken the "shared lib" build? Could you double check that you don't need to add "<span>clangDriver</span>" ?<br>
<br>
../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:61: error: undefined reference to 'clang::driver::types::lookupTypeForExtension(llvm::StringRef)'<br>
../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:63: error: undefined reference to 'clang::driver::types::onlyPrecompileType(clang::driver::types::ID)'</div>
<p></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Thanks!<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> cfe-commits <cfe-commits-bounces@lists.llvm.org> on behalf of Eric Liu via Phabricator via cfe-commits <cfe-commits@lists.llvm.org><br>
<b>Sent:</b> Thursday, May 24, 2018 10:44:26 AM<br>
<b>To:</b> ioeric@google.com; sammccall@google.com<br>
<b>Cc:</b> maskray@google.com; llvm-commits@lists.llvm.org; cfe-commits@lists.llvm.org<br>
<b>Subject:</b> [PATCH] D47187: [clangd] Skip .inc headers when canonicalizing header #include.</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL333188: [clangd] Skip .inc headers when canonicalizing header #include. (authored by ioeric, committed by ).<br>
Herald added a subscriber: llvm-commits.<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D47187">https://reviews.llvm.org/D47187</a><br>
<br>
Files:<br>
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp<br>
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.h<br>
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp<br>
clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp<br>
<br>
</div>
</span></font></div>
</body>
</html>