<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">You should use something like the git-svnrevert script to avoid having a git hash in the commit message. See
<a href="http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn">
http://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn</a> (I'm not sure if that works with the monorepo though).<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">It's also helpful to include a bit of context on why you're reverting (probably buildbot failures?).<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">llvm-commits <llvm-commits-bounces@lists.llvm.org> on behalf of Azharuddin Mohammed via llvm-commits <llvm-commits@lists.llvm.org><br>
<b>Reply-To: </b>Azharuddin Mohammed <azharudd@codeaurora.org><br>
<b>Date: </b>Thursday, May 24, 2018 at 2:40 PM<br>
<b>To: </b>"llvm-commits@lists.llvm.org" <llvm-commits@lists.llvm.org><br>
<b>Subject: </b>[compiler-rt] r333232 - Revert "[cmake] [ARM] Check if VFP is supported before including any VFP builtins"<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Author: azharudd<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Date: Thu May 24 14:36:27 2018<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">New Revision: 333232<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D333232-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=FwaI9wnqQkrJ7Piu5bGcWJEuc8UymfO1i-TGNMMgEg4&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D333232-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=FwaI9wnqQkrJ7Piu5bGcWJEuc8UymfO1i-TGNMMgEg4&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Log:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Revert "[cmake] [ARM] Check if VFP is supported before including any VFP builtins"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">This reverts commit 2a10f5da5acb1b51d0a2ecf13dca0bf1de859db2.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> compiler-rt/trunk/cmake/builtin-config-ix.cmake<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> compiler-rt/trunk/lib/builtins/CMakeLists.txt<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified: compiler-rt/trunk/cmake/builtin-config-ix.cmake<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_cmake_builtin-2Dconfig-2Dix.cmake-3Frev-3D333232-26r1-3D333231-26r2-3D333232-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=WPfN6o5Gltl1LoCDQJKu_YrtJxuGgXDZE8wFaxEOmo8&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_cmake_builtin-2Dconfig-2Dix.cmake-3Frev-3D333232-26r1-3D333231-26r2-3D333232-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=WPfN6o5Gltl1LoCDQJKu_YrtJxuGgXDZE8wFaxEOmo8&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">==============================================================================<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">--- compiler-rt/trunk/cmake/builtin-config-ix.cmake (original)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+++ compiler-rt/trunk/cmake/builtin-config-ix.cmake Thu May 24 14:36:27 2018<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">@@ -48,12 +48,6 @@ set(ALL_BUILTIN_SUPPORTED_ARCH ${X86} ${<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">include(CompilerRTUtils)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">include(CompilerRTDarwinUtils)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-# If targeting ARM, check if VFP is supported.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-if(CAN_TARGET_arm)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- string(REPLACE ";" " " _TARGET_arm_CFLAGS "${TARGET_arm_CFLAGS}")<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- check_compile_definition(__VFP_FP__ "${CMAKE_C_FLAGS} ${_TARGET_arm_CFLAGS}" COMPILER_RT_HAS_ARM_VFP)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-endif()<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">if(APPLE)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> find_darwin_sdk_dir(DARWIN_osx_SYSROOT macosx)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified: compiler-rt/trunk/lib/builtins/CMakeLists.txt<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_CMakeLists.txt-3Frev-3D333232-26r1-3D333231-26r2-3D333232-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=UfvUl9Z8Qy8jfqa68ohiBn5HLjFEm_YR1mV_ogd-vTA&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_builtins_CMakeLists.txt-3Frev-3D333232-26r1-3D333231-26r2-3D333232-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=UfvUl9Z8Qy8jfqa68ohiBn5HLjFEm_YR1mV_ogd-vTA&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">==============================================================================<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">--- compiler-rt/trunk/lib/builtins/CMakeLists.txt (original)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+++ compiler-rt/trunk/lib/builtins/CMakeLists.txt Thu May 24 14:36:27 2018<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">@@ -394,20 +394,11 @@ set(arm_Thumb1_VFPv2_SOURCES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> arm/unordsf2vfp.S)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">set(arm_Thumb1_icache_SOURCES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> arm/sync_synchronize.S)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-# If VFP is supported, include arm_Thumb1_SjLj_EH_SOURCES and<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-# arm_Thumb1_VFPv2_SOURCES in arm_Thumb1_SOURCES.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-if(COMPILER_RT_HAS_ARM_VFP)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- set(arm_Thumb1_SOURCES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- ${arm_Thumb1_JT_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- ${arm_Thumb1_SjLj_EH_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- ${arm_Thumb1_VFPv2_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- ${arm_Thumb1_icache_SOURCES})<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-else()<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- set(arm_Thumb1_SOURCES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- ${arm_Thumb1_JT_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">- ${arm_Thumb1_icache_SOURCES})<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-endif()<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+set(arm_Thumb1_SOURCES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+ ${arm_Thumb1_JT_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+ ${arm_Thumb1_SjLj_EH_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+ ${arm_Thumb1_VFPv2_SOURCES}<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+ ${arm_Thumb1_icache_SOURCES})<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">if(MINGW)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> set(arm_SOURCES<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">_______________________________________________<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">llvm-commits mailing list<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=EcYZfHcx5mlEWnVdWWtZq5SMjaH6wS54w-hJEwoVJ0E&e=">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=NsUEnvZEGaGrTL0HiDLKtfmtJfZKbsVK4QSuw7OjaOA&s=EcYZfHcx5mlEWnVdWWtZq5SMjaH6wS54w-hJEwoVJ0E&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
</div>
</body>
</html>