Note that the endianness values can be passed in to the llvm functions at runtime, there are non template versions of the write functions that accept endianness as arguments (that may be exactly what you used, btw, I didn’t read the patch in detail).<br><br>It’s a shame this object hierarchy was developed separately from the BinaryStream / StreamReader / StreamWriter interfaces, because it seems like there’s some overlap and it would serve this use case nicely <br><div class="gmail_quote"><div dir="ltr">On Fri, May 18, 2018 at 12:50 PM Peter Collingbourne via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rLLD332757: Support: Simplify endian stream interface. NFCI. (authored by pcc, committed by ).<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D47032?vs=147396&id=147573#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D47032?vs=147396&id=147573#toc</a><br>
<br>
Repository:<br>
  rLLD LLVM Linker<br>
<br>
<a href="https://reviews.llvm.org/D47032" rel="noreferrer" target="_blank">https://reviews.llvm.org/D47032</a><br>
<br>
Files:<br>
  wasm/WriterUtils.cpp<br>
<br>
<br>
Index: wasm/WriterUtils.cpp<br>
===================================================================<br>
--- wasm/WriterUtils.cpp<br>
+++ wasm/WriterUtils.cpp<br>
@@ -70,7 +70,7 @@<br>
<br>
 void wasm::writeU32(raw_ostream &OS, uint32_t Number, const Twine &Msg) {<br>
   debugWrite(OS.tell(), Msg + "[0x" + utohexstr(Number) + "]");<br>
-  support::endian::Writer<support::little>(OS).write(Number);<br>
+  support::endian::write(OS, Number, support::little);<br>
 }<br>
<br>
 void wasm::writeValueType(raw_ostream &OS, uint8_t Type, const Twine &Msg) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>