<div dir="ltr">Thanks Martin, Guillaume is having a look.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 17, 2018 at 10:07 AM, Martin Storsjö <span dir="ltr"><<a href="mailto:martin@martin.st" target="_blank">martin@martin.st</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">> On May 17, 2018, at 10:38, Clement Courbet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> <br>
> Author: courbet<br>
> Date: Thu May 17 00:38:21 2018<br>
> New Revision: 332579<br>
> <br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=332579&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=332579&view=rev</a><br>
> Log:<br>
> [llvm-exegesis] Update to cover latency through another opcode.<br>
> <br>
>    Restructuring the code to measure latency and uops.<br>
>    The end goal is to have this program spawn another process to deal with SIGILL and other malformed programs. It is not yet the case in this redesign, it is still the main program that runs the code (and may crash).<br>
>    It now uses BitVector instead of Graph for performance reasons.<br>
> <br>
>    <a href="https://reviews.llvm.org/D46821" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D46821</a><br>
> <br>
>    Authored by Guillaume Chatelet<br>
> <br>
> Added:<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/Assembler.cpp<br>
>      - copied, changed from r332455, llvm/trunk/tools/llvm-<wbr>exegesis/lib/<wbr>InMemoryAssembler.cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/Assembler.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/MCInstrDescView.<wbr>cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/MCInstrDescView.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/RegisterAliasing.<wbr>cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/RegisterAliasing.<wbr>h<br>
>    llvm/trunk/unittests/tools/<wbr>llvm-exegesis/X86/<wbr>RegisterAliasingTest.cpp<br>
> Removed:<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/<wbr>InMemoryAssembler.cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/<wbr>InMemoryAssembler.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/<wbr>InstructionSnippetGenerator.<wbr>cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/<wbr>InstructionSnippetGenerator.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/OperandGraph.cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/OperandGraph.h<br>
>    llvm/trunk/unittests/tools/<wbr>llvm-exegesis/<wbr>OperandGraphTest.cpp<br>
>    llvm/trunk/unittests/tools/<wbr>llvm-exegesis/X86/<wbr>InstructionSnippetGeneratorTes<wbr>t.cpp<br>
> Modified:<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/BenchmarkResult.<wbr>cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/BenchmarkResult.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/BenchmarkRunner.<wbr>cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/BenchmarkRunner.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/CMakeLists.txt<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/Latency.cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/Latency.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/LlvmState.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/Uops.cpp<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/lib/Uops.h<br>
>    llvm/trunk/tools/llvm-<wbr>exegesis/llvm-exegesis.cpp<br>
>    llvm/trunk/unittests/tools/<wbr>llvm-exegesis/CMakeLists.txt<br>
>    llvm/trunk/unittests/tools/<wbr>llvm-exegesis/X86/CMakeLists.<wbr>txt<br>
>    llvm/trunk/unittests/tools/<wbr>llvm-exegesis/X86/<wbr>InMemoryAssemblerTest.cpp<br>
<br>
</div></div>This seems to have failed to update unittests/tools/llvm-exegesis/<wbr>ARM/InMemoryAssemblerTest.cpp accordingly, which still refers to the removed InMemoryAssembler.h.<br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
// Martin</font></span></blockquote></div><br></div>