<div dir="ltr"><div><div>Sorry about that - not sure how that made it past my local checks.<br></div>Hopefully fixed here:<br></div><a href="https://reviews.llvm.org/rL332569" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>rL332569</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 16, 2018 at 9:15 PM, <span dir="ltr"><<a href="mailto:douglas.yung@sony.com" target="_blank">douglas.yung@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Sanjay,<br>
<br>
Your change is causing a failure on a bot, can you take a look?<br>
<br>
<a href="http://lab.llvm.org:8011/builders/clang-cmake-armv8-selfhost-neon/builds/598/steps/ninja%20check%202/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-cmake-armv8-<wbr>selfhost-neon/builds/598/<wbr>steps/ninja%20check%202/logs/<wbr>stdio</a><br>
<br>
FAIL: LLVM :: CodeGen/Thumb2/cross-rc-<wbr>coalescing-2.ll (24923 of 38795)<br>
******************** TEST 'LLVM :: CodeGen/Thumb2/cross-rc-<wbr>coalescing-2.ll' FAILED ********************<br>
Script:<br>
--<br>
/home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/stage2/bin/llc < /home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/llvm/test/CodeGen/Thumb2/<wbr>cross-rc-coalescing-2.ll -mtriple=thumbv7-apple-darwin9 -mcpu=cortex-a8 -arm-atomic-cfg-tidy=0 | /home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/stage2/bin/FileCheck /home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/llvm/test/CodeGen/Thumb2/<wbr>cross-rc-coalescing-2.ll<br>
--<br>
Exit Code: 2<br>
<br>
Command Output (stderr):<br>
--<br>
/home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/stage2/bin/llc: <stdin>:71:34: error: '%34' defined with type 'i1'<br>
<span class="gmail-"> %35 = fadd float 0.000000e+00, %34<br>
</span> ^<br>
FileCheck error: '-' is empty.<br>
FileCheck command line: /home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/stage2/bin/FileCheck /home/buildslave/buildslave/<wbr>clang-cmake-armv8-selfhost-<wbr>neon/llvm/test/CodeGen/Thumb2/<wbr>cross-rc-coalescing-2.ll<br>
<br>
--<br>
<br>
********************<br>
<br>
Douglas Yung<br>
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org">llvm-commits-bounces@<wbr>lists.llvm.org</a>] On Behalf Of<br>
> Sanjay Patel via llvm-commits<br>
> Sent: Wednesday, May 16, 2018 15:48<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> Subject: [llvm] r332548 - [Thumb] preserve test intent by removing undef<br>
> <br>
> Author: spatel<br>
> Date: Wed May 16 15:47:51 2018<br>
> New Revision: 332548<br>
> <br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=332548&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=332548&view=rev</a><br>
> Log:<br>
> [Thumb] preserve test intent by removing undef<br>
> <br>
> We need to clean up the DAG floating-point undef logic.<br>
> This process is similar to how we handled integer undef<br>
> logic in D43141.<br>
> <br>
> And as we did there, I'm trying to reduce the patch by<br>
> changing tests that would probably become meaningless<br>
> once we correct FP undef folding.<br>
> <br>
> Modified:<br>
> llvm/trunk/test/CodeGen/<wbr>Thumb2/cross-rc-coalescing-2.<wbr>ll<br>
> <br>
> Modified: llvm/trunk/test/CodeGen/<wbr>Thumb2/cross-rc-coalescing-2.<wbr>ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Thumb2/cross-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>CodeGen/Thumb2/cross-</a><br>
> rc-coalescing-2.ll?rev=332548&<wbr>r1=332547&r2=332548&view=diff<br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/CodeGen/<wbr>Thumb2/cross-rc-coalescing-2.<wbr>ll (original)<br>
> +++ llvm/trunk/test/CodeGen/<wbr>Thumb2/cross-rc-coalescing-2.<wbr>ll Wed May 16<br>
> 15:47:51 2018<br>
> @@ -35,14 +35,14 @@ bb8:<br>
> %5 = fmul float %4, %0 ; <float> [#uses=1]<br>
> %6 = fsub float %3, %5 ; <float> [#uses=1]<br>
> %7 = fmul float %4, %1 ; <float> [#uses=1]<br>
> - %8 = fadd float undef, %7 ; <float> [#uses=2]<br>
> + %8 = fadd float %7, %7<br>
> %9 = load float, float* %fi.1, align 4 ; <float> [#uses=2]<br>
> %10 = fsub float %9, %8 ; <float> [#uses=1]<br>
> %11 = fadd float %9, %8 ; <float> [#uses=1]<br>
> %12 = fsub float 0.000000e+00, %6 ; <float> [#uses=1]<br>
> - %13 = fsub float 0.000000e+00, undef ; <float> [#uses=2]<br>
> - %14 = fmul float undef, %0 ; <float> [#uses=1]<br>
> - %15 = fadd float %14, undef ; <float> [#uses=2]<br>
> + %13 = fsub float 0.000000e+00, %12<br>
> + %14 = fmul float %0, %0<br>
> + %15 = fadd float %14, %14<br>
> %16 = load float, float* %scevgep81, align 4 ; <float> [#uses=2]<br>
> %17 = fsub float %16, %15 ; <float> [#uses=1]<br>
> %18 = fadd float %16, %15 ; <float> [#uses=2]<br>
> @@ -68,6 +68,6 @@ bb8:<br>
> br i1 %34, label %bb8, label %bb9<br>
> <br>
> bb9: ; preds = %bb8<br>
> - %35 = fadd float 0.000000e+00, undef ; <float> [#uses=1]<br>
> + %35 = fadd float 0.000000e+00, %34<br>
> br label %bb7<br>
> }<br>
> <br>
> <br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>