<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">It's possible, it's supposed to be a non-functional change though (it's just a different path to the same result). We'll find out soon<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 8 May 2018, at 20:48, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" class="">peter@pcc.me.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">I see these failing bots:</div><div class=""><br class=""></div><a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-global-isel/builds/5477" class="">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-global-isel/builds/5477</a><br class=""><div class=""><a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/13131" class="">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/13131</a><br class=""></div><div class=""><br class=""></div><div class="">These culprits seem likely: r331816, r331819, r331820.</div><div class=""><br class=""></div><div class="">But it looks like only r331819 has been reverted.</div><div class=""><br class=""></div><div class="">I would suspect r331816 and/or r331820.</div><div class=""><br class=""></div><div class="">Peter</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, May 8, 2018 at 8:40 PM, Roman Tereshin <span dir="ltr" class=""><<a href="mailto:rtereshin@apple.com" target="_blank" class="">rtereshin@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class=""><div class=""></div><div class="">Hi Peter,</div><div class=""><br class=""></div><div class="">I have reverted my commit and the bots are still failing: <a class="">lab.llvm.org:8011/<wbr class="">builders/clang-cmake-aarch64-<wbr class="">global-isel/builds/5481</a></div><div class=""><br class=""></div><div class="">Best,</div><div class="">Roman</div><div class=""><div class="h5"><div class=""><br class="">On May 8, 2018, at 6:47 PM, Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank" class="">peter@pcc.me.uk</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">Hmm, it wouldn't actually be unreachable, you can reach it like this:<div class=""><br class=""></div><div class=""><div class="">.section .foo,"a",@11</div></div><div class=""><br class=""></div><div class="">If we encounter input like that, doing nothing is an acceptable thing to do.</div><div class=""><br class=""></div><div class="">Peter</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, May 8, 2018 at 5:50 PM, Daniel Sanders <span dir="ltr" class=""><<a href="mailto:daniel_l_sanders@apple.com" target="_blank" class="">daniel_l_sanders@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Peter,<br class="">
<br class="">
Shouldn't it call llvm_unreachable() so that an asserts build fails noisily rather than silently doing nothing?<br class="">
<div class="m_513356046031407298HOEnZb"><div class="m_513356046031407298h5"><br class="">
> On 8 May 2018, at 15:59, Peter Collingbourne via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
> <br class="">
> Author: pcc<br class="">
> Date: Tue May 8 15:59:05 2018<br class="">
> New Revision: 331821<br class="">
> <br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=331821&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=331821&view=rev</a><br class="">
> Log:<br class="">
> MC: Remove dead code. NFCI.<br class="">
> <br class="">
> We should never emit an SHT_DYNSYM into an object file.<br class="">
> <br class="">
> Modified:<br class="">
> llvm/trunk/lib/MC/ELFObjectWri<wbr class="">ter.cpp<br class="">
> <br class="">
> Modified: llvm/trunk/lib/MC/ELFObjectWri<wbr class="">ter.cpp<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=331821&r1=331820&r2=331821&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/llvm/trunk/lib/MC/ELFObj<wbr class="">ectWriter.cpp?rev=331821&r1=<wbr class="">331820&r2=331821&view=diff</a><br class="">
> ==============================<wbr class="">==============================<wbr class="">==================<br class="">
> --- llvm/trunk/lib/MC/ELFObjectWri<wbr class="">ter.cpp (original)<br class="">
> +++ llvm/trunk/lib/MC/ELFObjectWri<wbr class="">ter.cpp Tue May 8 15:59:05 2018<br class="">
> @@ -1149,7 +1149,6 @@ void ELFObjectWriter::writeSection(<wbr class="">const<br class="">
> }<br class="">
> <br class="">
> case ELF::SHT_SYMTAB:<br class="">
> - case ELF::SHT_DYNSYM:<br class="">
> sh_link = StringTableIndex;<br class="">
> sh_info = LastLocalSymbolIndex;<br class="">
> break;<br class="">
> <br class="">
> <br class="">
> ______________________________<wbr class="">_________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="m_513356046031407298gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class="">-- <div class="">Peter</div></div></div>
</div>
</div></blockquote></div></div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class="">-- <div class="">Peter</div></div></div>
</div>
</div></blockquote></div><br class=""></body></html>