<div dir="ltr">Yes, but I'll try to make it default because RequiresNullTerminator doesn't make sense in most cases, and I think it is just an inappropriate value as a default.<br></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Apr 27, 2018 at 8:55 AM Rafael Avila de Espindola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks!<br>
<br>
Maybe add a comment saying what the false is?<br>
<br>
Cheers,<br>
Rafael<br>
<br>
Rui Ueyama via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> writes:<br>
<br>
> Author: ruiu<br>
> Date: Fri Apr 27 08:32:04 2018<br>
> New Revision: 331045<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=331045&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=331045&view=rev</a><br>
> Log:<br>
> Do not set RequiresNullTerminator. NFC.<br>
><br>
> When reading object files, we don't need '\0' at end of each file.<br>
><br>
> Modified:<br>
>     lld/trunk/ELF/InputFiles.cpp<br>
><br>
> Modified: lld/trunk/ELF/InputFiles.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=331045&r1=331044&r2=331045&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=331045&r1=331044&r2=331045&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/ELF/InputFiles.cpp (original)<br>
> +++ lld/trunk/ELF/InputFiles.cpp Fri Apr 27 08:32:04 2018<br>
> @@ -63,7 +63,7 @@ Optional<MemoryBufferRef> elf::readFile(<br>
>  <br>
>    log(Path);<br>
>  <br>
> -  auto MBOrErr = MemoryBuffer::getFile(Path);<br>
> +  auto MBOrErr = MemoryBuffer::getFile(Path, -1, false);<br>
>    if (auto EC = MBOrErr.getError()) {<br>
>      error("cannot open " + Path + ": " + EC.message());<br>
>      return None;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>