<div dir="ltr">Yes, it did. Sorry, reverted with r330476.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 20, 2018 at 12:48 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Could this have caused this test failure?<div><a href="http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/11600" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-ppc64le-linux-<wbr>lnt/builds/11600</a></div><div><br></div><div>Peter</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Apr 20, 2018 at 11:03 AM, Alex Shlyapnikov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alekseyshl<br>
Date: Fri Apr 20 11:03:10 2018<br>
New Revision: 330458<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=330458&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=330458&view=rev</a><br>
Log:<br>
[Sanitizer] Internal Printf string precision argument + padding.<br>
<br>
Summary:<br>
Example:<br>
Printf("%.*s", 5, "123");<br>
should yield:<br>
'123 '<br>
<br>
In case Printf's requested string precision is larger than the string<br>
argument, the resulting string should be padded up to the requested<br>
precision.<br>
<br>
For the simplicity sake, implementing right padding only.<br>
<br>
Reviewers: eugenis<br>
<br>
Subscribers: kubamracek, delcypher, #sanitizers, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D45844" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4584<wbr>4</a><br>
<br>
Modified:<br>
compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc<br>
compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cc?rev=330458&r1=330457&r2=330458&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/sanitizer_print<wbr>f.cc?rev=330458&r1=330457&r2=<wbr>330458&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc Fri Apr 20 11:03:10 2018<br>
@@ -105,6 +105,8 @@ static int AppendString(char **buff, con<br>
break;<br>
result += AppendChar(buff, buff_end, *s);<br>
}<br>
+ while (result < precision)<br>
+ result += AppendChar(buff, buff_end, ' ');<br>
return result;<br>
}<br>
<br>
<br>
Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_printf_test.cc?rev=330458&r1=330457&r2=330458&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/tests/sanitizer<wbr>_printf_test.cc?rev=330458&r1=<wbr>330457&r2=330458&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc Fri Apr 20 11:03:10 2018<br>
@@ -146,8 +146,13 @@ TEST(Printf, Precision) {<br>
EXPECT_EQ(3U, len);<br>
EXPECT_STREQ("123", buf);<br>
len = internal_snprintf(buf, sizeof(buf), "%.*s", 6, "12345");<br>
- EXPECT_EQ(5U, len);<br>
- EXPECT_STREQ("12345", buf);<br>
+ EXPECT_EQ(6U, len);<br>
+ EXPECT_STREQ("12345 ", buf);<br>
+ // CHeck that precision does not overflow the smaller buffer, although<br>
+ // 10 chars is requested, it stops at the buffer size, 8.<br>
+ len = internal_snprintf(buf, 8, "%.*s", 10, "12345");<br>
+ EXPECT_EQ(10U, len); // The required size reported.<br>
+ EXPECT_STREQ("12345 ", buf);<br>
}<br>
<br>
} // namespace __sanitizer<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_4262684678973725306gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</font></span></div>
</blockquote></div><br></div>