<div dir="ltr">Sorry for that and I already reverted it.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 20, 2018 at 1:31 PM, Sean Fertile <span dir="ltr"><<a href="mailto:sfertile@ca.ibm.com" target="_blank">sfertile@ca.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-7541714790079867505socmaildefaultfont" dir="ltr" style="font-family:Arial,Helvetica,sans-serif;font-size:10.5pt"><div dir="ltr">Hi Alex,</div>
<div dir="ltr"> </div>
<div dir="ltr">I'm able to confirm locally this commit did break that test on several of the build bots. Can you have a look.</div>
<div dir="ltr"> </div>
<div dir="ltr">Thanks<br>Sean</div>
<div dir="ltr"> </div>
<blockquote dir="ltr" style="border-left:solid #aaaaaa 2px;margin-left:5px;padding-left:5px;direction:ltr;margin-right:0px"><div><div class="h5">----- Original message -----<br>From: Peter Collingbourne via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>Sent by: "llvm-commits" <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.<wbr>llvm.org</a>><br>To: Alex Shlyapnikov <<a href="mailto:alekseys@google.com" target="_blank">alekseys@google.com</a>><br>Cc: llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>Subject: Re: [compiler-rt] r330458 - [Sanitizer] Internal Printf string precision argument + padding.<br>Date: Fri, Apr 20, 2018 3:49 PM<br>
<div dir="ltr">Could this have caused this test failure?
<div><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_clang-2Dppc64le-2Dlinux-2Dlnt_builds_11600&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=WOYEvuKj2KZu3HxHogFRQCE8Affd3GERRdU53Ne8erE&e=" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-ppc64le-linux-<wbr>lnt/builds/11600</a></div>
<div> </div>
<div>Peter</div></div>
<div>
<div>On Fri, Apr 20, 2018 at 11:03 AM, Alex Shlyapnikov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alekseyshl<br>Date: Fri Apr 20 11:03:10 2018<br>New Revision: 330458<br><br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D330458-26view-3Drev&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=lxId1HemfQ5GrW9BpDVvqiAQvCXvOha2MaGtuTfvDAc&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=330458&view=rev</a><br>Log:<br>[Sanitizer] Internal Printf string precision argument + padding.<br><br>Summary:<br>Example:<br> Printf("%.*s", 5, "123");<br>should yield:<br> '123 '<br><br>In case Printf's requested string precision is larger than the string<br>argument, the resulting string should be padded up to the requested<br>precision.<br><br>For the simplicity sake, implementing right padding only.<br><br>Reviewers: eugenis<br><br>Subscribers: kubamracek, delcypher, #sanitizers, llvm-commits<br><br>Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D45844&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=1JWiVkL4I1OpNJ7Tmg0vIJfAhySHUnuIiBBHZ03Ea7M&e=" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4584<wbr>4</a><br><br>Modified:<br> compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc<br> compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc<br><br>Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc<br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_sanitizer-5Fcommon_sanitizer-5Fprintf.cc-3Frev-3D330458-26r1-3D330457-26r2-3D330458-26view-3Ddiff&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=IFA6iXTsxuFg_XK7hML_0U6MwAli8UPyQHvFogchclo&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/sanitizer_print<wbr>f.cc?rev=330458&r1=330457&r2=<wbr>330458&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc (original)<br>+++ compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_printf.cc Fri Apr 20 11:03:10 2018<br>@@ -105,6 +105,8 @@ static int AppendString(char **buff, con<br> break;<br> result += AppendChar(buff, buff_end, *s);<br> }<br>+ while (result < precision)<br>+ result += AppendChar(buff, buff_end, ' ');<br> return result;<br> }<br><br><br>Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc<br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_compiler-2Drt_trunk_lib_sanitizer-5Fcommon_tests_sanitizer-5Fprintf-5Ftest.cc-3Frev-3D330458-26r1-3D330457-26r2-3D330458-26view-3Ddiff&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=iw8w9Bs5nJgxe1QZNAMZaZTdrtSPXLnsQWN2xTlUUGI&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/tests/sanitizer<wbr>_printf_test.cc?rev=330458&r1=<wbr>330457&r2=330458&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc (original)<br>+++ compiler-rt/trunk/lib/sanitize<wbr>r_common/tests/sanitizer_<wbr>printf_test.cc Fri Apr 20 11:03:10 2018<br>@@ -146,8 +146,13 @@ TEST(Printf, Precision) {<br> EXPECT_EQ(3U, len);<br> EXPECT_STREQ("123", buf);<br> len = internal_snprintf(buf, sizeof(buf), "%.*s", 6, "12345");<br>- EXPECT_EQ(5U, len);<br>- EXPECT_STREQ("12345", buf);<br>+ EXPECT_EQ(6U, len);<br>+ EXPECT_STREQ("12345 ", buf);<br>+ // CHeck that precision does not overflow the smaller buffer, although<br>+ // 10 chars is requested, it stops at the buffer size, 8.<br>+ len = internal_snprintf(buf, 8, "%.*s", 10, "12345");<br>+ EXPECT_EQ(10U, len); // The required size reported.<br>+ EXPECT_STREQ("12345 ", buf);<br> }<br><br> } // namespace __sanitizer<br><br><br>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=d3_I3Nd6o1aLgPk-G3iqFkx4zT62kc-ySwpYPzzY-XY&e=" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a></blockquote></div>
<div> </div>--
<div data-smartmail="gmail_signature"><div dir="ltr">--
<div>Peter</div></div></div></div>
</div></div><div><font size="2" face="Default Monospace,Courier New,Courier,monospace"><div><div class="h5">______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br></div></div><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=vE89RddfSAMwAmW9D-c51sqQCl8tXHenTEyBrBeQeeA&m=44j85w_M0UtdfV9zXiUc1cz71_CmTtBnXRN6TbwI9w4&s=d3_I3Nd6o1aLgPk-G3iqFkx4zT62kc-ySwpYPzzY-XY&e=" target="_blank">https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__lists.<wbr>llvm.org_cgi-2Dbin_mailman_<wbr>listinfo_llvm-2Dcommits&d=<wbr>DwIGaQ&c=jf_iaSHvJObTbx-<wbr>siA1ZOg&r=vE89RddfSAMwAmW9D-<wbr>c51sqQCl8tXHenTEyBrBeQeeA&m=<wbr>44j85w_M0UtdfV9zXiUc1cz71_<wbr>CmTtBnXRN6TbwI9w4&s=d3_<wbr>I3Nd6o1aLgPk-G3iqFkx4zT62kc-<wbr>ySwpYPzzY-XY&e=</a></font></div></blockquote>
<div dir="ltr"> </div></div><br>
</blockquote></div><br></div>