<div dir="ltr">Test case?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Apr 13, 2018 at 5:15 PM Heejin Ahn via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aheejin<br>
Date: Fri Apr 13 17:12:12 2018<br>
New Revision: 330079<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=330079&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=330079&view=rev</a><br>
Log:<br>
[WebAssembly] Fix a bug in MachineBasicBlock::findDebugLoc() call<br>
<br>
Summary:<br>
InsertPos is within the bacic block `Header`, so `findDebugLoc()` should<br>
be called on not `MBB` but `Header` instead.<br>
<br>
Reviewers: yurydelendik<br>
<br>
Subscribers: jfb, dschuff, aprantl, sbc100, jgravelle-google, sunfish, JDevlieghere, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D45648" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45648</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp?rev=330079&r1=330078&r2=330079&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp?rev=330079&r1=330078&r2=330079&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp (original)<br>
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp Fri Apr 13 17:12:12 2018<br>
@@ -147,9 +147,10 @@ static void PlaceBlockMarker(<br>
   }<br>
<br>
   // Add the BLOCK.<br>
-  MachineInstr *Begin = BuildMI(*Header, InsertPos, MBB.findDebugLoc(InsertPos),<br>
-                                TII.get(WebAssembly::BLOCK))<br>
-                            .addImm(int64_t(WebAssembly::ExprType::Void));<br>
+  MachineInstr *Begin =<br>
+      BuildMI(*Header, InsertPos, Header->findDebugLoc(InsertPos),<br>
+              TII.get(WebAssembly::BLOCK))<br>
+          .addImm(int64_t(WebAssembly::ExprType::Void));<br>
<br>
   // Mark the end of the block.<br>
   InsertPos = MBB.begin();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>